Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change suggested badge colour #767

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Conversation

prisae
Copy link
Contributor

@prisae prisae commented Oct 28, 2018

I suggest to change the suggested badge-color from green to blue. Red-green is often used to show if tests or builds were successful or not (readthedocs, travis, etc), and red-orange-green is often used to show the status (coveralls, codacy). However, the asv-badge is a static link, indicating that it is benchmarked with asv. So I suggest to show it in blue, as for instance used by Zenodo for its doi, or py pypi and conda for the version number; static info.

From asv to asv.

Of course, any user can adjust the badge to his likes anyway, but I thought it would be better to have blue in the suggested markdown.

I suggest to change the suggested badge-color from green to blue. Red-green is often used to show if tests or builds were successful or not (readthedocs, travis, etc), and red-orange-green is often used to show the status (coveralls, codacy). However, the asv-badge is a static link, indicating that it is benchmarked with asv. So I suggest to show it in blue, as for instance used by Zenodo for its doi, or py pypi and conda for the version number; static info.
@pv pv merged commit ec7bccc into airspeed-velocity:master Oct 28, 2018
@prisae prisae deleted the patch-1 branch October 28, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants