Fix PEP-8 violations reported by flake8 on asv folder #988
Conversation
LucyJimenez
changed the title
LucyJimenez
changed the title
LucyJimenez
changed the title
LucyJimenez
changed the title
.github/workflows/ci.yml
Outdated
| - name: flake8 validating correct file(s) | ||
| run: flake8 asv/step_detect.py asv/runner.py asv/results.py asv/repo.py asv/main.py |
There was a problem hiding this comment.
Are all the files in this PR added here? Seems like some are missing, is there a reason for it?
There was a problem hiding this comment.
Thank you, Marc. You are right! I'm going to include all the respective files.
asv/statistics.py
Outdated
| @@ -387,7 +388,7 @@ def binom_pmf(n, k, p): | |||
| logp = math.log(p) | |||
| log1mp = math.log(1 - p) | |||
| return math.exp(lgamma(1 + n) - lgamma(1 + n - k) - lgamma(1 + k) | |||
| + k*logp + (n - k)*log1mp) | |||
| + k*logp + (n - k)*log1mp) | |||
There was a problem hiding this comment.
Seems like spaces are missing around operators. Isn't flake8 complaining?
There was a problem hiding this comment.
It was my mistake. I'm working on fixing it!
asv/util.py
Outdated
| @@ -531,7 +543,7 @@ def get_content(header=None): | |||
| if env and WIN and sys.version_info < (3,): | |||
| # Environment keys and values cannot be unicode | |||
| def _fix_env(s): | |||
| return s.encode('mbcs') if isinstance(s, unicode) else s | |||
| return s.encode('mbcs') if isinstance(s, unicode) else s # noqa | |||
There was a problem hiding this comment.
Another space is missing before the hash. Also, we need the error we are ignoring after noqa.
asv/util.py
Outdated
| @@ -1127,9 +1147,9 @@ def format_text_table(rows, num_headers=0, | |||
|
|
|||
| def _datetime_to_timestamp(dt, divisor): | |||
| delta = dt - datetime.datetime(1970, 1, 1) | |||
| microseconds = (delta.days * 86400 + delta.seconds) * 10**6 + delta.microseconds | |||
| microseconds = ((delta.days * 86400 + delta.seconds) * 10**6 + delta.microseconds) | |||
There was a problem hiding this comment.
Spaces around the ** operator
There was a problem hiding this comment.
I think spaces are not necessary, and flake8 doesn't point to it as a mistake.
|
CI is red, looks like you're breaking the tests. This PR is too big, maybe better to start by splitting it like in 3, one for util.py, one for step_detect.py which are quite large files, and one for the rest. This will help find the problem, as well as making it easier to review, even if it takes few iterations. |
|
@datapythonista Thank you for your advice. Now, this PR is shorter than before, and de CI is working! |
There was a problem hiding this comment.
Thanks @LucyJimenez, really nice.
We'll merge it after the release, but looks perfect.
|
Thanks @LucyJimenez |
Check flake8 and fix issues pep8 related on asv/asv folder for: