Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dashboard for Splits #136

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

leruaa
Copy link

@leruaa leruaa commented Nov 25, 2023

As discussed on Discord, here is a first draft of a chart showing pool asset distribution, including splits.

image

I'm not sure if this should be integrated to the claim process or on a "Dashboard" page, wdyt?

Copy link
Contributor

@gpxl-dev gpxl-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great - thanks for taking the time to write code in the same style as the rest.

The vizualisation is really informative and useful, the only thing is it requires quite a bit of 'insider' knowledge about how the system works (e.g. without looking it up idk the difference between withdraw and distribute).

I'd be interested to get some design/ux feedback from other contributors on this as I think it would be nice to either have an "advanced" setting that would toggle this display, or to explain it a little more.

I think with either of the above we could also build in the functionality to interact with the splits contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants