Delegates #1320
Merged
Delegates #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons to ensure both contracts compile simultaneously
… contract accordingly. Removed the delegateFactory contract
… contract accordingly. Removed the delegateFactory contract
Merge to Beta for NPM Publishing
Publish betas to NPM
Publish beta packages to NPM
update staking token addresses, deploy staking to testnets (#1267)
…d tracking of remaining rule allowance
…dded a test case when SENDER_AMOUNT is above requirements
Delegates
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
dmosites
reviewed
Aug 15, 2024
| ) { | ||
| revert InvalidSignerAmount(); | ||
| } | ||
| if (rule.ruleExpiry < _expiry) revert RuleExpired(); |
There was a problem hiding this comment.
This should compare to block timestamp rather than order expiry:
if (rule.ruleExpiry <= block.timestamp) revert RuleExpired();
dmosites
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.