-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts enhancements #1321
Scripts enhancements #1321
Conversation
populate_deploy_commits.js
Outdated
for (const branch of branches) { | ||
try { | ||
const commit = execSync( | ||
`git log -1 --format=%H ${branch} -- ${contractPath}/contracts` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check ${contractPath}/contracts/deploys.js
specifically.
Because |
Agreed - |
* Scripts enhancements (#1321) * Added checks to validate target deployment address matches mainnet * Added storing of commit hashes upon deployment to track deployed code * Created script to populate the latest deploy commits * Renamed deploy commits script for clarity * Updated module declarations * Removed script to populate hashes * prompt language update --------- Co-authored-by: Don Mosites <mosites@gmail.com> * Bump micromatch from 4.0.5 to 4.0.8 (#1323) Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 1.6.7 to 1.7.7 (#1324) Bumps [axios](https://github.com/axios/axios) from 1.6.7 to 1.7.7. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.6.7...v1.7.7) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Increased Delegate test coverage to 100% --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Don Mosites <mosites@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Scripts enhancements (#1321) * Added checks to validate target deployment address matches mainnet * Added storing of commit hashes upon deployment to track deployed code * Created script to populate the latest deploy commits * Renamed deploy commits script for clarity * Updated module declarations * Removed script to populate hashes * prompt language update --------- Co-authored-by: Don Mosites <mosites@gmail.com> * Bump micromatch from 4.0.5 to 4.0.8 (#1323) Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 1.6.7 to 1.7.7 (#1324) Bumps [axios](https://github.com/axios/axios) from 1.6.7 to 1.7.7. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.6.7...v1.7.7) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Increased Delegate test coverage to 100% (#1325) * Fix/audit fixes (#1327) * Increased Delegate test coverage to 100% * Implemented audit fixes * Removed unused import --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Smartcontrart <100962328+smartcontrart@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Solves issue #1316