Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate and SwapERC20 Finalizations #1322

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Delegate and SwapERC20 Finalizations #1322

merged 4 commits into from
Aug 28, 2024

Conversation

dmosites
Copy link
Contributor

  • Adds and updates comments.
  • Updates Rule parameter names.
  • Modifies errors for Delegate and SwapERC20.
  • Modifies SetRule event.

smartcontrart and others added 3 commits August 28, 2024 14:00
@smartcontrart @dmosites
Use of hashTypeData for code clarity and check chain ID (#1318)
fd9a894 
* publish libraries 4.2.1-beta.0

* Removed redundant chain ID checks

* Removed unused error and reduced max_error count by one

* Removed unused error from swap and reduced MAX_ERROR by 1

---------

Co-authored-by: don mosites <mosites@gmail.com>
@dmosites
Merge branch 'beta' of github.com:airswap/airswap-protocols into develop
fc557e7
@dmosites
naming, comments, adjustments
46e1b24
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Aug 28, 2024 •
edited
Loading

Delegate and SwapERC20 Finalizations

Generated at commit: cf1362937e0cb22bb70ae4c40acdc6606aedace6

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 1
1
0
7
25
34
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dmosites dmosites merged commit cf58ace into beta Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartcontrart smartcontrart smartcontrart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmosites @smartcontrart