888: Refactor of useHistoricalTransactions #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #888
The old useHistoricalTransactions stopped working because of the
swapContract.filters.SwapERC20update, it now only accepts nonce and signerWallet to reduce gas cost.Because of this you're only able to get orders where the account is the signerWallet. It won't work for orders with senderWallet.
Having no other choice we have to traverse all the logs of the swapContract. Hopefully this doesn't cause any issues when the logs get too large. If block limit is reached the logs will be fetched in increments so should be fine.
Right now it's not able to determine if an order is LastLook or RFQ. But since we also have OTC orders now we might have to rethink the labeling of transactions. I've added a separate ticket for that stuff: #891