Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: uvicorn --workers doesn't run multiple AsgiFastStream instances #1874

Closed
Lancetnik opened this issue Oct 27, 2024 · 1 comment
Closed

Bug: uvicorn --workers doesn't run multiple AsgiFastStream instances #1874

Lancetnik opened this issue Oct 27, 2024 · 1 comment
Assignees
@Sehat1137
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Lancetnik
Copy link
Member

Lancetnik commented Oct 27, 2024 •
edited
Loading

We should check both cases

  1. faststream run main:asgi --workers 2
  2. uvicorn main:asgi --workers 2
@Lancetnik Lancetnik added the bug Something isn't working label Oct 27, 2024
Lancetnik added a commit that referenced this issue Nov 6, 2024
@Lancetnik
fix (#1874): call factory once in regular case
12d808b
@Lancetnik Lancetnik mentioned this issue Nov 6, 2024
Merged
13 tasks
@Lancetnik Lancetnik added the help wanted Extra attention is needed label Nov 7, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
@Lancetnik @kumaranvpl
fix (#1856): call factory once in regular case (#1898)
9c25b7b 
* fix (#1874): call factory once in regular case

* chore: bump version

* lint: fix mypy

* chore: fix pydantic 2.10 compatibility

---------

Co-authored-by: Kumaran Rajendhiran <kumaran@airt.ai>
@Sehat1137
Copy link
Contributor

still actual

Sehat1137 pushed a commit to Sehat1137/faststream that referenced this issue Nov 24, 2024
fix: airtai#1874 support workers for ASGI FastStream
26aca1a
@Sehat1137 Sehat1137 mentioned this issue Nov 24, 2024
Merged
13 tasks
Sehat1137 pushed a commit to Sehat1137/faststream that referenced this issue Nov 24, 2024
fix: airtai#1874 support workers for ASGI FastStream
80e7412 
- Add support workers via gunicorn

- Add support fd & unix socket

- Add new external params `--bind`

- Separate `--bind` params from app
github-merge-queue bot pushed a commit that referenced this issue Nov 29, 2024
@Sehat1137 @Lancetnik
fix: #1874 support workers for ASGI FastStream (#1936)
90aaf57 
* fix: #1874 support workers for ASGI FastStream

- Add support workers via gunicorn

- Add support fd & unix socket

- Add new external params `--bind`

- Separate `--bind` params from app

* test: extend test for CLI

* docs: generate API References

* fix: change creation of ASGIRunner

* lint: fix CI

---------

Co-authored-by: sehat1137 <edox1j2n@duck.com>
Co-authored-by: Sehat1137 <Sehat1137@users.noreply.github.com>
Co-authored-by: Nikita Pastukhov <diementros@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sehat1137 Sehat1137

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sehat1137 @Lancetnik