Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CLI support for AsgiFastStream #1782

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

Sehat1137
Copy link
Contributor

@Sehat1137 Sehat1137 commented Sep 11, 2024

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Sehat1137 Sehat1137 force-pushed the asgi-support branch 2 times, most recently from 323e3e0 to 482347b Compare September 16, 2024 10:19
@Sehat1137 Sehat1137 changed the title draft: feat: add CLI support for AsgiFastStream feat: add CLI support for AsgiFastStream Sep 16, 2024
@Sehat1137 Sehat1137 marked this pull request as ready for review September 16, 2024 10:40
@Sehat1137 Sehat1137 force-pushed the asgi-support branch 5 times, most recently from fe34761 to 662ceff Compare September 22, 2024 18:10
Lancetnik
Lancetnik previously approved these changes Sep 23, 2024
@Lancetnik Lancetnik added the enhancement New feature or request label Sep 23, 2024
@Lancetnik Lancetnik added this pull request to the merge queue Sep 23, 2024
Merged via the queue into airtai:main with commit a8b6572 Sep 23, 2024
30 checks passed
@Sehat1137 Sehat1137 deleted the asgi-support branch September 23, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants