-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-hints + refactoring #2018
Merged
Merged
Type-hints + refactoring #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linter edit
a way better style of code
because i didnt do it
…rtai#2005) * chore(deps): bump the pip group across 1 directory with 6 updates Bumps the pip group with 6 updates in the / directory: | Package | From | To | | --- | --- | --- | | [mkdocs-material](https://github.com/squidfunk/mkdocs-material) | `9.5.48` | `9.5.49` | | [mypy](https://github.com/python/mypy) | `1.13.0` | `1.14.0` | | [ruff](https://github.com/astral-sh/ruff) | `0.8.2` | `0.8.4` | | [semgrep](https://github.com/returntocorp/semgrep) | `1.99.0` | `1.101.0` | | [coverage[toml]](https://github.com/nedbat/coveragepy) | `7.6.1` | `7.6.9` | | [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) | `0.24.0` | `0.25.0` | Updates `mkdocs-material` from 9.5.48 to 9.5.49 - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.5.48...9.5.49) Updates `mypy` from 1.13.0 to 1.14.0 - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.13.0...v1.14.0) Updates `ruff` from 0.8.2 to 0.8.4 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.8.2...0.8.4) Updates `semgrep` from 1.99.0 to 1.101.0 - [Release notes](https://github.com/returntocorp/semgrep/releases) - [Changelog](https://github.com/semgrep/semgrep/blob/develop/CHANGELOG.md) - [Commits](semgrep/semgrep@v1.99.0...v1.101.0) Updates `coverage[toml]` from 7.6.1 to 7.6.9 - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.6.1...7.6.9) Updates `pytest-asyncio` from 0.24.0 to 0.25.0 - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: mkdocs-material dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pip - dependency-name: mypy dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pip - dependency-name: ruff dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pip - dependency-name: semgrep dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pip - dependency-name: coverage[toml] dependency-type: direct:production update-type: version-update:semver-patch dependency-group: pip - dependency-name: pytest-asyncio dependency-type: direct:production update-type: version-update:semver-minor dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com> * Update pyproject.toml * Update pyproject.toml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pastukhov Nikita <nikita@pastukhov-dev.ru>
Co-authored-by: Pastukhov Nikita <nikita@pastukhov-dev.ru>
* fix: Disabled excessive throttling for BatchSubscriber. * fix: Use separate thread for confluent kafka consumer. * refactor: Added run_in_executor function. * fix: Stop consumer client after consumer tasks are stopped.
* Feat: add tests * Feat: add concurrent subscriber * Fix: revert ruff * Fix: again ruff * Fix: fastapi init * Fix: inheritance --------- Co-authored-by: Daniil Dumchenko <dumchenko.de@sibvaleo.com> Co-authored-by: Pastukhov Nikita <nikita@pastukhov-dev.ru>
* feat: declare queue/exchange binding * docs: generate API References * docs: reverting the changes and adding queue/exchange binding to the documentation * docs: reverting the changes and adding queue/exchange binding to the documentation * docs: reverting the changes and adding queue/exchange binding to the documentation * docs: generate API References * test: added some testing for the doc code snippet * chore: polish docs * tests: fix RMQ bind test --------- Co-authored-by: MagicAbdel <MagicAbdel@users.noreply.github.com> Co-authored-by: Nikita Pastukhov <diementros@yandex.ru>
Lancetnik
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, seems like there are some fixes required
- remove RMQ overload changes
- restore broken docstrings
- correct Redis overloading according to
producer.publish
signature - correct not broker only, but
publisher.publish
signature as well - correct changed tests
Lancetnik
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix code style, add overload for publish method
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)