Confluent kafka producer refactoring. #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DABND19
commented
Jan 4, 2025
|
|
||
| # should be sync to prevent segfault | ||
| self.producer.produce(topic, **kwargs) | ||
|
|
||
| if not no_confirm: | ||
| await result_future | ||
| return await result_future |
There was a problem hiding this comment.
DABND19
force-pushed
the
feat/confluent-kafka-producer-refactoring
branch
from
6ecdf73 to
774ecc3
Compare
DABND19
changed the title
Lancetnik
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AsyncConfluentProducerAsyncConfluentProducer.publishmethod now satisfies the contractAsyncConfluentFastProducertype hints fixesType of change
Please delete options that are not relevant.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-analysis.sh