Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscriber iterator #2039

Draft
wants to merge 6 commits into
base: 0.6.0
Choose a base branch
from
Draft

Subscriber iterator #2039

wants to merge 6 commits into from

Conversation

ApostolFet
Copy link

Description

Asynchronous generator over aio-pika iterator to implement an iterator for rabbit mq subscriber

Fixes #1881

Type of change

  • New feature (a non-breaking change that adds functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

Lancetnik
Lancetnik reviewed Jan 14, 2025
View reviewed changes
faststream/rabbit/subscriber/usecase.py Outdated
async for raw_message in queue_iter:
raw_message = cast("IncomingMessage", raw_message)

msg: RabbitMessage | None = await process_msg( # type: ignore[assignment]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process_message return None if only the original message is None.

So, we should return RabbitMessage everytime

Lancetnik
Lancetnik requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@Lancetnik Lancetnik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add __aiter__ method to the SubscriberProto parent as well

@Lancetnik Lancetnik added the enhancement New feature or request label Jan 14, 2025
@ApostolFet ApostolFet marked this pull request as draft January 24, 2025 18:41
@ApostolFet ApostolFet changed the title Subscriber iterator for rabbit mq Subscriber iterator Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lancetnik Lancetnik Lancetnik requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ApostolFet @Lancetnik