Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchase: 名前空間の外から名前空間内の変数に代入できるように #321

Closed
wants to merge 5 commits into from

Conversation

ikasoba
Copy link
Collaborator

@ikasoba ikasoba commented Sep 4, 2023

resolve #311

What

  • 名前空間の外から名前空間内の変数に代入できるように
    • 名前空間のスコープが名前空間内で定義された変数を変更する際、親のスコープの変数を参照することで解消

Why

Additional info (optional)

テストも書いておきました。

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 94.91% and project coverage change: +0.17% 🎉

Comparison is base (bc94751) 87.90% compared to head (25a7b37) 88.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   87.90%   88.07%   +0.17%     
==========================================
  Files          20       20              
  Lines        3291     3372      +81     
  Branches      542      562      +20     
==========================================
+ Hits         2893     2970      +77     
- Misses        387      391       +4     
  Partials       11       11              
Files Changed Coverage Δ
src/interpreter/scope.ts 93.36% <94.00%> (+0.23%) ⬆️
src/interpreter/index.ts 90.64% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ikasoba ikasoba closed this Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

名前空間内で定義した変数を外部からでも変更できるように
2 participants