Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 仮引数をparamにリネーム #829

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

uzmoi
Copy link
Member

@uzmoi uzmoi commented Oct 27, 2024

What

タイトルの通り

Why

Resolve #750

Additional info (optional)

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/type.ts 40.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/interpreter/index.ts 94.30% <100.00%> (+8.50%) ⬆️
src/interpreter/util.ts 69.23% <100.00%> (+1.25%) ⬆️
src/interpreter/value.ts 100.00% <100.00%> (ø)
src/node.ts 85.71% <ø> (-12.66%) ⬇️
src/parser/plugins/validate-keyword.ts 88.42% <100.00%> (-0.19%) ⬇️
src/parser/plugins/validate-type.ts 100.00% <100.00%> (+17.64%) ⬆️
src/parser/syntaxes/common.ts 93.75% <100.00%> (+4.22%) ⬆️
src/parser/syntaxes/expressions.ts 92.51% <100.00%> (+3.32%) ⬆️
src/parser/syntaxes/statements.ts 97.35% <100.00%> (+4.09%) ⬆️
src/parser/visit.ts 100.00% <100.00%> (+5.26%) ⬆️
... and 1 more

... and 19 files with indirect coverage changes

@FineArchs
Copy link
Member

一応ホスト向けの変更を含むので、ChangelogにFor Hostsとして記載をお願いします。

@uzmoi uzmoi merged commit 7d565c1 into aiscript-dev:master Oct 29, 2024
4 checks passed
@uzmoi uzmoi deleted the rename-arg-param branch October 29, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fn.argsの命名を見直す
5 participants