Transition repository from absolute to relative paths #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/Generate New Packages.bat # packages/building.md # packages/gci_air_gap/README.md # packages/netlab_core/README.md # packages/netlab_core/netlab_core_customizations.xml
aisgbnok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR transitions the repository from absolute paths to relative paths.
Why
Previously this repository had to be cloned in the exact same spot. It was required to have a path of
C:\provisioning\. This was somewhat annoying. Moving to relative paths means that this repository can be stored anywhere. Executing package builds or scripts will now use relative paths and are no longer constricted to an absolute path ofC:\provisioning\....Drawbacks
The only main annoyance is that now instead of requiring the path to be absolute, you must execute commands and scripts at the root of the
packagesdirectory. Using relative paths means their source or start has to be the same or they don't know how to get to their destination. I prefer this over being forced to use absolute paths everywhere, but it's something to be aware of.