Rename functions to something more verb-like #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Antonios, thanks for your contribution! I also prefer verb-like names. I'll merge it, but will release a new version later, when more notable changes came. Could you update |
|
@aishek But, the only public API you expose, is the axiosRateLimit function, not the AxiosRateLimit (note the capital "A"). All the changes to AxiosRateLimit are internal. I think there is no need to notify any user of the package. What do you think? |
ghost
mentioned this pull request
|
Oh, I've missed it. You're right. |
|
@AntoniosProvidakis just merged all requests and published version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the API is better when functions use verb-like names.