Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced handling of \ character in run, py, r, vision steps #206

Closed
kensoh opened this issue Jun 7, 2018 · 2 comments
Closed

Enhanced handling of \ character in run, py, r, vision steps #206

kensoh opened this issue Jun 7, 2018 · 2 comments
Assignees
Labels

Comments

@kensoh
Copy link
Member

kensoh commented Jun 7, 2018

Follow-up from #200 - the character would be treated as escape character now. It should ideally be handled as a backslash and be passed on to the target integration. See if there is a way to implement this and still preserve backward compatibility. Because some users may have used '\\' in order to send '\'. If blindly replace very '\' with '\\' it can make their scripts break or work in a way that's not intended.

@kensoh
Copy link
Member Author

kensoh commented Jun 7, 2018

below looks like need to convert '\' to '\\'

  • run
  • r
  • py
  • vision

@kensoh kensoh self-assigned this Jun 7, 2018
@kensoh kensoh added the query label Jun 7, 2018
@kensoh kensoh changed the title Handling of \ character in run, py, vision step Handling of \ character in run, py, r, vision steps Jun 7, 2018
kensoh added a commit that referenced this issue Jun 7, 2018
breaks backward compatibility to move to stable state standard
@kensoh
Copy link
Member Author

kensoh commented Jun 7, 2018

@Aussiroth @lohvht - solution found. The commit 297f37d breaks backward compatibility to move to stable state standard. [END_OF_LINE] token is used during buffering phase in order not to replace incorrectly during parsing. The backward compatibility broken for example -

py open('c:\\\\nest\\\\file.txt','w') in existing scripts can be used to open a file. but supporting this will mean py open('c:\\nest\\file.txt','w') becomes py open('c:\nest\file.txt','w') which is breaking the future stable state where what is sent is what is received by python.

@kensoh kensoh closed this as completed Jun 7, 2018
@kensoh kensoh changed the title Handling of \ character in run, py, r, vision steps Enhanced handling of \ character in run, py, r, vision steps Jun 8, 2018
@kensoh kensoh added feature and removed query labels Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant