Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with select step - original design of containing value fail for edge cases #592

Closed
kensoh opened this issue Oct 20, 2019 · 1 comment
Labels

Comments

@kensoh
Copy link
Member

kensoh commented Oct 20, 2019

In tagui_header.js, the following line

if (!found && opt.value.indexOf(valueToMatch) !== -1)

has to be changed to the following

if (!found && opt.value == valueToMatch)

The original design was to match when the option contains the value provided. But this loose definition clearly now encounters an edge case where the values are '-1', '0', '1', '2', '3'..

Providing '1' as value would match with '-1' since '-1' contains '1'). Making this change may cause some existing user scripts to fail (assuming that the search is based on contains).

But is necessary change, otherwise, there is no way to click on the option with '1', as first spotted in this edge case - tebelorg/RPA-Python#71

@kensoh
Copy link
Member Author

kensoh commented Oct 20, 2019

Bug fixed with above commit. Fix now available in cutting edge version -

https://github.com/kelaberetiv/TagUI#set-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant