Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhantomJS version outdated - use updated copy from website for OpenSSL v1.1 #932

Closed
gauravkeerthi opened this issue Feb 7, 2021 · 11 comments
Assignees
Labels

Comments

@gauravkeerthi
Copy link

suggest that the code library for phantomjs is updated to the newest version from https://phantomjs.org/
I've tried the code with the new version and it works.

@gauravkeerthi gauravkeerthi changed the title phantomjs version is outdate phantomjs version is outdated Feb 7, 2021
@kensoh
Copy link
Member

kensoh commented Feb 7, 2021

Hi Gaurav, thanks for raising this! Can you tell me more what you mean by the code library and how to replicate any error?

I've checked the PhantomJS URL above, the downloaded version is v2.1.1, and that's the version packaged with TagUI.

Here's a video with more contextual details of above findings - https://www.youtube.com/watch?v=I4HoSzD38FU

@kensoh kensoh added the query label Feb 7, 2021
@kensoh kensoh changed the title phantomjs version is outdated PhantomJS version is outdated - latest is v2.1.1 already, pending more details Feb 7, 2021
@kensoh kensoh changed the title PhantomJS version is outdated - latest is v2.1.1 already, pending more details PhantomJS version is outdated - is already latest v2.1.1, pending more details Feb 7, 2021
@gauravkeerthi
Copy link
Author

ref to this: #86 (comment)

@gauravkeerthi
Copy link
Author

anyway when i downloaded the code it threw up an error. i updated the phantomjs and it works. not sure what the reason was.
and I'm still using libressl 2.8.3

@kensoh
Copy link
Member

kensoh commented Feb 8, 2021

Thanks Gaurav for raising this!

It looks like though both copies have same version, the file size differs. We'll keep the issue open to investigate further onto whether to change the package or the solution at #86 or work out another implementation that can be more seamless.

downloaded copy

download

packaged copy

mac_package

@kensoh kensoh changed the title PhantomJS version is outdated - is already latest v2.1.1, pending more details PhantomJS version is outdated - is already latest v2.1.1, to check further Feb 8, 2021
@kensoh kensoh changed the title PhantomJS version is outdated - is already latest v2.1.1, to check further PhantomJS version is outdated - is already latest v2.1.1, to investigate further Feb 8, 2021
@kensoh
Copy link
Member

kensoh commented Feb 26, 2021

Adding on another datapoint from my colleague that above is true for him as well on Big Sur release.

This PhantomJS version from the website will have to be included into TagUI in the next release.

@kensoh kensoh self-assigned this Mar 3, 2021
@kensoh
Copy link
Member

kensoh commented Mar 5, 2021

Another datapoint from another colleague that version from website works for OpenSSL v1.1.

This is confirmed, to use that PhantomJS v2.1.1 instead of the existing packaged PJS v2.1.1.

@kensoh kensoh changed the title PhantomJS version is outdated - is already latest v2.1.1, to investigate further PhantomJS version is outdated - need updated copy from website for OpenSSL v1.1 Mar 5, 2021
@kensoh kensoh changed the title PhantomJS version is outdated - need updated copy from website for OpenSSL v1.1 PhantomJS version outdated - need updated copy from website for OpenSSL v1.1 Mar 5, 2021
@kensoh kensoh added bug and removed query labels Mar 5, 2021
@kensoh
Copy link
Member

kensoh commented Mar 5, 2021

Re-assigning as a bug introduced with newer versions of Mac OS. To be fixed in next release. Or users can download directly from below link. After unzipping, put contents of unzipped folder into tagui/src/phantomjs folder.

https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-macosx.zip

@kensoh
Copy link
Member

kensoh commented Mar 7, 2021

Until next release, have updated installation troubleshooting instructions to use latest PJS from provided zip URL

@kensoh
Copy link
Member

kensoh commented Mar 7, 2021

Fyi @ruthtxh

I've updated the Having problems link here to be more visible (some people will miss it when it is the last line)
https://tagui.readthedocs.io/en/latest/setup.html

Have updated troubleshooting steps for macOS to download new PhantomJS zip to replace existing phantomjs
https://tagui.readthedocs.io/en/latest/setup_troubleshooting.html#troubleshooting-windows

In the next release, will review the various components of TagUI to put in the latest possible (including PJS).

@kensoh kensoh changed the title PhantomJS version outdated - need updated copy from website for OpenSSL v1.1 PhantomJS version outdated - use updated copy from website for OpenSSL v1.1 Mar 13, 2021
@kensoh
Copy link
Member

kensoh commented May 20, 2021

Looks like similar issue for Linux? (from #787 (comment)) Needs to refresh.

https://phantomjs.org/download.html

Screenshot 2021-05-21 at 6 54 35 AM

@kensoh
Copy link
Member

kensoh commented Jun 18, 2021

Closing issue, change included in latest packaged release - https://github.com/kelaberetiv/TagUI/releases/tag/v6.46.0

@kensoh kensoh closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants