-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhantomJS version outdated - use updated copy from website for OpenSSL v1.1 #932
Comments
Hi Gaurav, thanks for raising this! Can you tell me more what you mean by the code library and how to replicate any error? I've checked the PhantomJS URL above, the downloaded version is v2.1.1, and that's the version packaged with TagUI. Here's a video with more contextual details of above findings - https://www.youtube.com/watch?v=I4HoSzD38FU |
ref to this: #86 (comment) |
anyway when i downloaded the code it threw up an error. i updated the phantomjs and it works. not sure what the reason was. |
Thanks Gaurav for raising this! It looks like though both copies have same version, the file size differs. We'll keep the issue open to investigate further onto whether to change the package or the solution at #86 or work out another implementation that can be more seamless. downloaded copy packaged copy |
Adding on another datapoint from my colleague that above is true for him as well on Big Sur release. This PhantomJS version from the website will have to be included into TagUI in the next release. |
Another datapoint from another colleague that version from website works for OpenSSL v1.1. This is confirmed, to use that PhantomJS v2.1.1 instead of the existing packaged PJS v2.1.1. |
Re-assigning as a bug introduced with newer versions of Mac OS. To be fixed in next release. Or users can download directly from below link. After unzipping, put contents of unzipped folder into tagui/src/phantomjs folder. https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-macosx.zip |
Until next release, have updated installation troubleshooting instructions to use latest PJS from provided zip URL |
Fyi @ruthtxh I've updated the Having problems link here to be more visible (some people will miss it when it is the last line) Have updated troubleshooting steps for macOS to download new PhantomJS zip to replace existing phantomjs In the next release, will review the various components of TagUI to put in the latest possible (including PJS). |
Looks like similar issue for Linux? (from #787 (comment)) Needs to refresh. |
Closing issue, change included in latest packaged release - https://github.com/kelaberetiv/TagUI/releases/tag/v6.46.0 |
suggest that the code library for phantomjs is updated to the newest version from https://phantomjs.org/
I've tried the code with the new version and it works.
The text was updated successfully, but these errors were encountered: