Potential fix for #289 and #295 #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#289 - enclose wait step with casper.then() in order to make dynamic wait delay in scope for access #295 - PHP 7 issues warning message which is not observed with PHP 5. this change removes the warning by avoiding an empty $repo_data[0]. ie increment repo_count only if there is already data in the array, otherwise discard header and start filling from $repo_data[0].
|
Thanks Ken! I'll take a look though it. I was doing some automation stuff recently when I found a case where there might be issue with the new wait, want to recheck in case. |
|
No probs Alvin! If you would like me to have a look, free feel to email me on your replication use case which isn't working with the updated wait implementation. For the PHP notice issue, thought it would be good to resolve as older PHP 5 gets phased out, more users would receive the warning message. So I went ahead to have a look and made above PR. |
Aussiroth
approved these changes
Nov 6, 2018
|
Oh nice... Thanks Alvin, copying Ryzal @ryzalk for committing to master branch - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#289 - enclose wait step with casper.then() in order to make dynamic wait delay in scope for access
#295 - PHP 7 issues warning message which is not observed with PHP 5. this change removes the warning by avoiding an empty $repo_data[0]. ie increment repo_count only if there is already data in the array, otherwise discard header and start filling from $repo_data[0]. For the datatable (custom_csv_file portion), don't drop header as there is a dummy [iteration] header to let users reference current datatable iteration number.