draft hack to exit Chrome cleanly on Windows #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siowyisheng, raised PR #699 to improve on this, more details there |
siowyisheng
pushed a commit
that referenced
this pull request
Feb 3, 2020
* check chrome_pref before hacking * pipe to nul for access denied error
siowyisheng
pushed a commit
that referenced
this pull request
Mar 10, 2020
siowyisheng
pushed a commit
that referenced
this pull request
Mar 10, 2020
* check chrome_pref before hacking * pipe to nul for access denied error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@siowyisheng draft hack for your review and testing on Windows. Be sure to back up your Chrome preferences beforehand as it will overwrite your file.
I can't find related information for the gawk command used in TagUI, thus need to do some trial and error from this initial best guess from my Mac.