Merge pull request #201 from aitok-ai/jinshi/fix-dev-images

Update dev-images.yml: remove docker hub login
aitok-ai · May 24, 2024 · 7217857 · 7217857
2 parents 42e8e02 + 1cb3a0c
commit 7217857
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/.github/workflows/dev-images.yml b/.github/workflows/dev-images.yml
@@ -44,12 +44,12 @@ jobs:
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
-      # Login to Docker Hub
-      - name: Login to Docker Hub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
+      # # Login to Docker Hub
+      # - name: Login to Docker Hub
+      #   uses: docker/login-action@v3
+      #   with:
+      #     username: ${{ secrets.DOCKERHUB_USERNAME }}
+      #     password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       # Prepare the environment
       - name: Prepare environment
@@ -66,7 +66,5 @@ jobs:
           tags: |
             ghcr.io/${{ github.repository_owner }}/${{ matrix.image_name }}:${{ github.sha }}
             ghcr.io/${{ github.repository_owner }}/${{ matrix.image_name }}:latest
-            ${{ secrets.DOCKERHUB_USERNAME }}/${{ matrix.image_name }}:${{ github.sha }}
-            ${{ secrets.DOCKERHUB_USERNAME }}/${{ matrix.image_name }}:latest
           platforms: linux/amd64,linux/arm64
           target: ${{ matrix.target }}
diff --git a/.github/workflows/trunk-test.yml b/.github/workflows/trunk-test.yml
@@ -31,7 +31,8 @@ jobs:
         run: |
           cp .env.example .env
           echo "version=$(date +'%Y-%m-%d')-${{ github.sha }}" > client/public/assets/version.txt
-          docker-compose build
+          # docker-compose build # This no longer works after docker-compose.yaml is updated
+          docker build . -t librechat:latest --target node # build the container image directly
 
       # Tag it properly before push to github
       - name: tag image and push