ssl: Support using client-side SSL certificates, closes #253 and #447 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context.verify_mode = ssl.CERT_REQUIRED | ||
| context.load_cert_chain(certfile=self.certfile, keyfile=self.keyfile) | ||
| try: | ||
| conn = context.wrap_socket(socket.socket(socket.AF_INET), |
There was a problem hiding this comment.
use socket.create_connection instead of creating a plain AF_INET socket and connecting with it.
|
Travis Tests failed due to various pylint and other issues. |
…pkp#447 Kafka 0.9.0+ supports using SSL encrypted connections authenticated with client certificates. This adds support for these. After this when using SSL/TLS for Kafka broker connections, TLSv1.0+ is used for authentication, protocols earlier than that are deprecated from the get go as insecure. If keyfile/certificate are left empty, the client can still use SSL/TLS for the transport, but in that case the server must be configured to accept unauthenticated users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka 0.9.0+ supports using SSL encrypted connections authenticated
with client certificates. This adds support for these. After this
when using SSL/TLS for Kafka broker connections,
TLSv1.0+ is used for authentication, protocols earlier than that are
deprecated from the get go as insecure.
If keyfile/certificate are left empty, the client can still use
SSL/TLS for the transport, but in that case the server must be
configured to accept unauthenticated users.