Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Log Request Content-Negotiation #162

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

schrieveslaach
Copy link
Contributor

The Content-Negotiation for getting logs of services has been improved so that browsers that don't send text/plain in the accept header are able to download the logs from the PREvant UI.

Copy link
Contributor

@samuchila samuchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple of my own minor mistakes. Please have a look at them.
Otherwise, the approach is great, approving the PR.

api/src/apps/routes/logs.rs Outdated Show resolved Hide resolved
api/src/apps/routes/logs.rs Outdated Show resolved Hide resolved
The Content-Negotiation for getting logs of services has been improved
so that browsers that don't send `text/plain` in the accept header are
able to download the logs from the PREvant UI.
@schrieveslaach schrieveslaach merged commit db938ae into master Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants