Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "enableDoubleFindToReplace" option #5346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nunziotocci
Copy link

Issue #, if available:
Brings back the behavior that #2653 complained about behind an option.

Description of changes:
Add "enableDoubleFindToReplace" option. This allows you to press Ctrl-F while the find window is open to toggle the replace option. I'm used to it, and so are the people at my company.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@InspiredGuy
Copy link
Contributor

Thank you for the contribution. Could you please add the new option to the types declaration in ace.d.ts, add a test for the new option, and expose the option in the kitchen sink? Please refer to #5233 as an example for those

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7a6b83e) 87.41% compared to head (06a294f) 87.42%.
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5346      +/-   ##
==========================================
+ Coverage   87.41%   87.42%   +0.01%     
==========================================
  Files         574      574              
  Lines       45613    45613              
  Branches     6935     6935              
==========================================
+ Hits        39873    39878       +5     
+ Misses       5740     5735       -5     
Flag Coverage Δ
unittests 87.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/editor.js 80.60% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants