fix: switch aria-selected to aria-current for webkit #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5416 +/- ##
==========================================
- Coverage 87.59% 87.59% -0.01%
==========================================
Files 583 584 +1
Lines 46389 46409 +20
Branches 7018 7021 +3
==========================================
+ Hits 40636 40651 +15
- Misses 5753 5758 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marinsokol5
reviewed
Dec 11, 2023
src/autocomplete/popup.js
Outdated
| @@ -153,7 +153,7 @@ class AcePopup { | |||
| selected.setAttribute("aria-setsize", popup.data.length); | |||
| selected.setAttribute("aria-posinset", row + 1); | |||
| selected.setAttribute("aria-describedby", "doc-tooltip"); | |||
| selected.setAttribute("aria-selected", "true"); | |||
| selected.setAttribute(userAgent.isSafari ? "aria-current" : "aria-selected", "true"); | |||
There was a problem hiding this comment.
We might wanna do the isSafari check more above to group Safari related changes in one place.
There was a problem hiding this comment.
@sokomari refactored the PR a bit to make it clearer, do you think this is an improvement?
marinsokol5
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: NA
Description of changes: follow-up to #5403, we set the role to
menuitemfor items in the completer popup on webkit browsers butaria-selectedis not allowed formenuitemroles triggering customers who run automated a11y tests. This changes it to aria-current which is allowed for this role.Screen.Recording.2023-12-06.at.16.53.21.mov
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.