Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow custom version number release script #5699

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

akoreman
Copy link
Contributor

Issue #, if available: NA

Description of changes: Currently, when releasing a new Ace version, the new version number is automatically picked up through conventional commits. Sometimes we want to be able to override this.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (fcf6384) to head (a9803a6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5699   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files         598      598           
  Lines       43588    43588           
  Branches     7162     7162           
=======================================
  Hits        37932    37932           
  Misses       5656     5656           
Flag Coverage Δ
unittests 87.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

echo "version number for the build is" $VERSION_NUM
echo "recommended version number for the build is" $VERSION_NUM

read -p "do you want to continue with the recommended version number? [y/n] " yn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the default is y but not mentioned.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, you can ignore this, seems like the rest of the file also uses that pattern

@akoreman akoreman merged commit 713abb6 into ajaxorg:master Dec 17, 2024
3 checks passed
@akoreman akoreman deleted the release_script branch December 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants