Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show msgbox with confirmation del/clear #35

Merged
merged 1 commit into from
Jan 7, 2022
Merged

show msgbox with confirmation del/clear #35

merged 1 commit into from
Jan 7, 2022

Conversation

saaremaa
Copy link
Contributor

@saaremaa saaremaa commented Dec 1, 2021 •
edited by ajaxray
Loading

Added a confirmation window when deleting a project or clean the tasks.

fix: #28
fix: #21

2021-12-01_21-03-50
2021-12-01_21-04-18

@ajaxray
Copy link
Owner

ajaxray commented Dec 2, 2021 •
edited
Loading

Hi @saaremaa,

Thanks for the awesome feature! 🤩

Just a few points to discuss:

  • I've removed Delete Task #8 from the fixing list because it's related to deleting an individual task.

@saaremaa
Copy link
Contributor Author

saaremaa commented Dec 5, 2021

My mistake - you are right. #8 must be removed.

@ajaxray ajaxray merged commit e466e2f into ajaxray:master Jan 7, 2022
@ajaxray
Copy link
Owner

ajaxray commented Jan 7, 2022

Hi @saaremaa ,

Thanks again for the awesome addition!

I have done a little refactoring in your implementation of showing modal confirmation.
Can you please have a look and let me know if what I've done is Okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete task/project confirmation Add confirmation for sensitive actions
2 participants
@saaremaa @ajaxray