Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video rotates from landscape to portrait Firefox Android #1993

Open
caeci11ius opened this issue Apr 1, 2024 · 10 comments
Open

Video rotates from landscape to portrait Firefox Android #1993

caeci11ius opened this issue Apr 1, 2024 · 10 comments

Comments

@caeci11ius
Copy link

This was working really nicely on the Android version of Firefox until about a week ago. Since then, it's been causing the video player to rotate back to portrait periodically during playback (sometimes seems associated with skips, but not always). Happens within a few minutes regardless.

Phone is configured with automatic rotation disabled. Commencing in portrait, Firefox will rotate to landscape when fullscreen playback is selected. After a few minutes of playback with sponsorblock running, the video will rotate back to portrait. Skipping forward/back using double tap restores landscape orientation, as does exiting and re-entering fullscreen. Disabling plugin fixes the issue.

Plugin version 5.5.9
Firefox version 124.1.0
Pixel 7 Pro 5 March 2024 firmware

@Wolfdv1
Copy link

Wolfdv1 commented Apr 1, 2024

+1 came to report the exact same behaviour, as well as doing so randomly and during skips, seems to sometimes react to touch input to the screen

Version Info:

{
"debug": {
    "userAgent": "Mozilla/5.0 (Android 13; Mobile; rv:124.0) Gecko/124.0 Firefox/124.0",
    "platform": "Linux armv81",
    "language": "en-GB",
    "extensionVersion": "5.5.9"
},
"config": {
    "allowScrollingToEdit": true,
    "autoSkipOnMusicVideosUpdate": true,
    "categoryPillUpdate": true,
    "chapterCategoryAdded": true,
    "dontShowNotice": false,
    "hideUploadButtonPlayerControls": true,
    "invidiousInstances": 33,
    "isVip": false,
    "minutesSaved": 953.4461867000002,
    "permissions": {
        "sponsor": true,
        "selfpromo": true,
        "exclusive_access": true,
        "interaction": true,
        "intro": true,
        "outro": true,
        "preview": true,
        "music_offtopic": true,
        "filler": true,
        "poi_highlight": true,
        "chapter": false
    },
    "showPopupDonationCount": 2,
    "showZoomToFillError2": false,
    "skipCount": 1201,
    "defaultCategory": "chooseACategory",
    "renderSegmentsAsChapters": false,
    "whitelistedChannels": 0,
    "forceChannelCheck": false,
    "sponsorTimesContributed": 0,
    "submissionCountSinceCategories": 0,
    "showTimeWithSkips": true,
    "disableSkipping": false,
    "muteSegments": true,
    "fullVideoSegments": true,
    "fullVideoLabelsOnThumbnails": true,
    "manualSkipOnFullVideo": false,
    "trackViewCount": true,
    "trackViewCountInPrivate": true,
    "trackDownvotes": true,
    "trackDownvotesInPrivate": false,
    "noticeVisibilityMode": 3,
    "hideVideoPlayerControls": false,
    "hideInfoButtonPlayerControls": false,
    "hideDeleteButtonPlayerControls": false,
    "hideSkipButtonPlayerControls": false,
    "hideDiscordLaunches": 0,
    "hideDiscordLink": false,
    "supportInvidious": false,
    "serverAddress": "Default server address",
    "minDuration": 0,
    "skipNoticeDuration": 4,
    "audioNotificationOnSkip": false,
    "checkForUnlistedVideos": false,
    "testingServer": false,
    "refetchWhenNotFound": true,
    "ytInfoPermissionGranted": false,
    "allowExpirements": true,
    "showDonationLink": true,
    "showUpsells": true,
    "showNewFeaturePopups": true,
    "donateClicked": 0,
    "autoHideInfoButton": true,
    "autoSkipOnMusicVideos": false,
    "scrollToEditTimeUpdate": false,
    "showChapterInfoMessage": true,
    "darkMode": true,
    "showCategoryGuidelines": true,
    "showCategoryWithoutPermission": false,
    "showSegmentNameInChapterBar": true,
    "useVirtualTime": true,
    "showSegmentFailedToFetchWarning": true,
    "deArrowInstalled": false,
    "showDeArrowPromotion": true,
    "showDeArrowInSettings": true,
    "shownDeArrowPromotion": false,
    "cleanPopup": false,
    "categoryPillColors": {},
    "skipKeybind": {
        "key": "Enter"
    },
    "skipToHighlightKeybind": {
        "key": "Enter",
        "ctrl": true
    },
    "startSponsorKeybind": {
        "key": ";"
    },
    "submitKeybind": {
        "key": "'"
    },
    "actuallySubmitKeybind": {
        "key": "'",
        "ctrl": true
    },
    "previewKeybind": {
        "key": ";",
        "ctrl": true
    },
    "nextChapterKeybind": {
        "key": "ArrowRight",
        "ctrl": true
    },
    "previousChapterKeybind": {
        "key": "ArrowLeft",
        "ctrl": true
    },
    "closeSkipNoticeKeybind": {
        "key": "Backspace"
    },
    "categorySelections": [
        {
            "name": "sponsor",
            "option": 2
        },
        {
            "name": "poi_highlight",
            "option": 1
        },
        {
            "name": "exclusive_access",
            "option": 0
        },
        {
            "name": "chapter",
            "option": 0
        }
    ],
    "payments": {
        "licenseKey": null,
        "lastCheck": 0,
        "lastFreeCheck": 0,
        "freeAccess": false,
        "chaptersAllowed": false
    },
    "colorPalette": {
        "red": "#780303",
        "white": "#ffffff",
        "locked": "#ffc83d"
    },
    "barTypes": {
        "preview-chooseACategory": {
            "color": "#ffffff",
            "opacity": "0.7"
        },
        "sponsor": {
            "color": "#00d400",
            "opacity": "0.7"
        },
        "preview-sponsor": {
            "color": "#007800",
            "opacity": "0.7"
        },
        "selfpromo": {
            "color": "#ffff00",
            "opacity": "0.7"
        },
        "preview-selfpromo": {
            "color": "#bfbf35",
            "opacity": "0.7"
        },
        "exclusive_access": {
            "color": "#008a5c",
            "opacity": "0.7"
        },
        "interaction": {
            "color": "#cc00ff",
            "opacity": "0.7"
        },
        "preview-interaction": {
            "color": "#6c0087",
            "opacity": "0.7"
        },
        "intro": {
            "color": "#00ffff",
            "opacity": "0.7"
        },
        "preview-intro": {
            "color": "#008080",
            "opacity": "0.7"
        },
        "outro": {
            "color": "#0202ed",
            "opacity": "0.7"
        },
        "preview-outro": {
            "color": "#000070",
            "opacity": "0.7"
        },
        "preview": {
            "color": "#008fd6",
            "opacity": "0.7"
        },
        "preview-preview": {
            "color": "#005799",
            "opacity": "0.7"
        },
        "music_offtopic": {
            "color": "#ff9900",
            "opacity": "0.7"
        },
        "preview-music_offtopic": {
            "color": "#a6634a",
            "opacity": "0.7"
        },
        "poi_highlight": {
            "color": "#ff1684",
            "opacity": "0.7"
        },
        "preview-poi_highlight": {
            "color": "#9b044c",
            "opacity": "0.7"
        },
        "filler": {
            "color": "#7300FF",
            "opacity": "0.9"
        },
        "preview-filler": {
            "color": "#2E0066",
            "opacity": "0.7"
        }
    }
}
}

@Bucketsmith
Copy link

I guess this is the problem I keep having on Android Firefox, as well.

@Wolfdv1
Copy link

Wolfdv1 commented Jun 9, 2024

Update:

Based on the time that I think this bug started happening, I found the firefox releases around that time and after trying v122 of Firefox android with sponsor block, the issue is not present. Must've been a change in Firefox Android 122.0.1+ that is causing this

In case anyone wants to rush using an outdated version to continue using sponsor block without this issue:
https://github.com/mozilla-mobile/firefox-android/releases/tag/fenix-v122.0.1 (you could also use a beta of 122 instead to have a separate app for just streaming videos with sponsor block)

@whitequark
Copy link

I'm also experiencing this issue.

@caeci11ius
Copy link
Author

caeci11ius commented Sep 14, 2024

As a semi-workaround, this still happens if you enable auto-rotation, but you won't notice it mostly. The exception is if your device is flat on a table or something where the orientation isn't clear (in which case picking it up will fix).

Annoying, but mostly does the job if you can handle having autorotation switched on (I found I mostly can, though can cause the odd issue using phone in bed). Still be nice if it was fixed though given it used to just work properly...might be why few people seem to have noticed though.

And while I'm here: still happening in Firefox 130.

@Wolfdv1
Copy link

Wolfdv1 commented Sep 15, 2024 via email

@Bucketsmith
Copy link

Tap forward or backward to move 10s, then the other way to come back where you left.
It will revert back to fullscreen landscape.

Sidenote, outdated versions run the risk of unpatched security flaws, it is not recommended to use them.

@whitequark
Copy link

I would have to destroy my Firefox profile to downgrade, since Android no longer allows downgrading applications over an old installation :(

@Wolfdv1
Copy link

Wolfdv1 commented Sep 16, 2024 via email

@whitequark
Copy link

Thanks for looking into the issue! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants