Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gecko ID to the extension #190

Closed
wants to merge 2 commits into from
Closed

Add a gecko ID to the extension #190

wants to merge 2 commits into from

Conversation

TheFrenchGhosty
Copy link

Some browsers (like GNU Icecat) will mark an add-on as corrupt if the manifest.json doesn't contain a gecko ID.

This PR fixes that.

For more details see: ysard/cookie-quick-manager#75

@TheFrenchGhosty
Copy link
Author

TheFrenchGhosty commented Dec 9, 2019

I just noticed that a gecko ID is included in the firefox_manifest-extra.json but sadly it isn't working that way and it really needs to be in the manifest.json

@ajayyy
Copy link
Owner

ajayyy commented Dec 9, 2019

Doesn't the addons store add it automatically? It doesn't work in chrome if added (that's why it is not there)

@TheFrenchGhosty
Copy link
Author

Sadly no it needs to be added manually into the file... I guess the solution is to do 2 different manifest.json, one for each browser.

@ajayyy
Copy link
Owner

ajayyy commented Dec 9, 2019

Are you downloading it from the addons store or from the repo?

@TheFrenchGhosty
Copy link
Author

I tried both, the problem is here for both.

See this gif for the store:

sponsorblock

@ajayyy ajayyy added the stuck label Dec 10, 2019
@ajayyy
Copy link
Owner

ajayyy commented Dec 19, 2019

This applies to Firefox versions <= 48: https://stackoverflow.com/a/56823677/1985387.

I have a fear that adding it back will result in Firefox Sync issues.

@ajayyy
Copy link
Owner

ajayyy commented Jan 11, 2020

Latest extension now has it

@TheFrenchGhosty
Copy link
Author

Amazing! It can now be installed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants