unify response headers from different scan methods & new ScanFile endpoint #51
Conversation
allow scanning with the SCANFILE method of clamd
| fmt.Printf(time.Now().Format(time.RFC3339)+" Scan result for: %v, %v\n", part.FileName(), s) | ||
| } | ||
|
|
||
| handleScanResults(response, part.FileName(), w) |
There was a problem hiding this comment.
This will falsely return a 200 OK if a FormPost with multiple files are used to call the /scan endpoint and the first file is clean, but the second one contains a virus, once you w.WriteHeader(http.Status), the response status will not change if you write it again. Maybe you are aware of this, considering your comment about limitations. This PR fixes that bug
There was a problem hiding this comment.
You're right - this is of course a security hole. Hope the maintainer merges your PR... then we could add more endpoints and get rid of some code duplications.
There was a problem hiding this comment.
Yes, it's good that you're also interested in adding functionality and patching holes, it gives some potential for the future of the project. I'm also interested in enhancement and bug fixes.
There was a problem hiding this comment.
Gentlemen, thanks a lot for your contributions. I did not react until now simply because I did not notice your open PRs. Sorry for that. Will try to set Github alerts for PRs going forward.
As a next step, can you update and test your changes against the current code base (fixed the database update)?
This package already provides different scanning endpoints, including one to scan files on a (mounted) filesystem (scanPath).
This pull request tries to unify the response headers from the different scan methods and provides an additional /scanFile endpoint that uses the simplest scanning method of clamd (SCANFILE instead of ALLMATCHSCANFILE).
I also updated the documentation.
Generally, there are limitations with the current approach, as the headers and the JSON response is written multiple times if several files were scanned (e.g. multipart binary or when given a path instead of a file to the scanPath/scanFile endpoints). But changing that would of course hurt backwards compatibility.