Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Delete Yesterday's Commit #85

Closed
mlajkim opened this issue Jan 6, 2025 · 0 comments · Fixed by #86
Closed

Feat: Delete Yesterday's Commit #85

mlajkim opened this issue Jan 6, 2025 · 0 comments · Fixed by #86
Labels
enhancement New feature or request

Comments

@mlajkim
Copy link
Contributor

mlajkim commented Jan 6, 2025

Background

We want to implement a new feature that allows users to delete their action group’s commits from the previous day. This ensures that the data stored in the app remains accurate and reflects the user’s actual actions.

For instance, imagine a user commits to an action group called “No consumption after 8 PM” at 8 PM, indicating they are done eating for the day. Later at 11 PM, they give in and eat but forget to update or delete the action group. Currently, there’s no way to correct this after a day has passed.

With the new “yesterday deletion” feature, users will have the ability to delete the previous day’s action group commits, ensuring their records are truthful and up-to-date.

TODOs

- [ ] API implementation is required
- [ ] Implement an option to delete the yesterday's commitment
- [ ] Since yesterday’s commits cannot be undone once deleted, it’s essential to include a confirmation dialog or warning message to ensure users are fully aware of the action’s permanence
@mlajkim mlajkim added the enhancement New feature or request label Jan 6, 2025
This was referenced Jan 6, 2025
Merged
Merged
@mlajkim mlajkim linked a pull request Jan 6, 2025 that will close this issue
Feat: Delete Yesterday's Commit #86
Merged
3 tasks
mlajkim added a commit to ajktown/api that referenced this issue Jan 8, 2025
@mlajkim
Feat: new endpoint DELETE /api/v1/action-groups/{id}/yesterday (#154)
1415734 
# Background

![image](https://github.com/user-attachments/assets/dd1f60d5-c639-4f8e-8ea1-26c37763ea2e)
ajktown/ConsistencyGPT#85

## What's done
Implement a new endpoint `DELETE /api/v1/action-groups/{id}/yesterday`

## What are the related PRs?
- N/A

## Checklist Before PR Review
- [x] The following has been handled:
  - `Draft` is set for this PR
  - `Title` is checked
  - `Background` is filled
  - `Assignee` is set
  - `Labels` are set
  - `Development` is linked if related issue exists

## Checklist (Right Before PR Review Request)
- [x] The following has been handled:
  - Final Operation Check is done
  - Mobile View Operation Check is done
  - Make this PR as an open PR
  - `What's done` is filled & matches to the actual changes

## Checklist (Reviewers)
- [x] Review if the following has been handled:
  - Review Code
  - `Checklist Before PR Review` is correctly handled
  - `Checklist (Right Before PR Review Request)` is correctly handled
- Check if there are any other missing TODOs (Checklists) that are not
yet listed
  - Check if issue under `Development` is fully handled if exists
mlajkim added a commit that referenced this issue Jan 8, 2025
@mlajkim
Feat: Delete Yesterday's Commit (#86)
1febaec 
# Background

![image](https://github.com/user-attachments/assets/83125df4-a2d7-4a3b-bdbb-84ddf106b550)
#85

## What's done
### Yesterday's commitment is done as shown:

![image](https://github.com/user-attachments/assets/43d7ddda-f1c6-4006-8e06-79b952d7e62a)
### Yesterday's Deletion is Enabled:

![image](https://github.com/user-attachments/assets/2646492b-a51c-4164-857b-281fd556c17d)
### Warning Dialog is shown:

![image](https://github.com/user-attachments/assets/9f7632d6-6384-467f-a7e4-c77cfab71e64)
### Yesterday's Deletion is Done:

![image](https://github.com/user-attachments/assets/a9379617-5e84-4033-8810-7839fbc6c892)
### Yesterday's Deletion is now disabled as it no longer exists:

![image](https://github.com/user-attachments/assets/8ee595e7-7a07-442e-8882-377140d9c3ed)



## What are the related PRs?
- #85

## Checklist Before PR Review
- [x] The following has been handled:
  - `Draft` is set for this PR
  - `Title` is checked
  - `Background` is filled
  - `Assignee` is set
  - `Labels` are set
  - `Development` is linked if related issue exists

## Checklist (Right Before PR Review Request)
- [x] The following has been handled:
  - Final Operation Check is done
  - Mobile View Operation Check is done
  - Make this PR as an open PR
  - `What's done` is filled & matches to the actual changes

## Checklist (Reviewers)
- [x] Review if the following has been handled:
  - Review Code
  - `Checklist Before PR Review` is correctly handled
  - `Checklist (Right Before PR Review Request)` is correctly handled
- Check if there are any other missing TODOs (Checklists) that are not
yet listed
  - Check if issue under `Development` is fully handled if exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Delete Yesterday's Commit ajktown/ConsistencyGPT
1 participant
@mlajkim