Skip to content

Commit

Permalink
Sherlock 98.md: (#577)
Browse files Browse the repository at this point in the history
* Create standardized PR templates for contracts (#539)

This PR creates three github PR templates that should be followed:
* `logic_src_changes.md`
* `cosmetic_src_changes.md`
* `testing_or_misc_nonsrc_changes.md`

To learn more about how GH templates work -> https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

Co-authored-by: Ian Harvey <iharvey@comcast.net>

* Single template (#546)

* merged all of the templates into one so the text will auto fill when a PR is created.
* was running into this issue documented here with auto fill -> https://stackoverflow.com/questions/52139192/github-pull-requests-template-not-showing

* add reentrancy guard to PositionManager.mint(); update mint natspec

---------

Co-authored-by: Ian Harvey <ith.harvey@gmail.com>
Co-authored-by: Ian Harvey <iharvey@comcast.net>
Co-authored-by: Mike <mikehathaway@makerdao.com>
  • Loading branch information
4 people authored Feb 8, 2023
1 parent bb03b38 commit 2e1d8da
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/PositionManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ contract PositionManager is ERC721, PermitERC721, IPositionManager, Multicall, R
*/
function mint(
MintParams calldata params_
) external override returns (uint256 tokenId_) {
) external override nonReentrant returns (uint256 tokenId_) {
tokenId_ = _nextId++;

// revert if the address is not a valid Ajna pool
Expand Down
5 changes: 3 additions & 2 deletions src/interfaces/position/IPositionManagerOwnerActions.sol
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ interface IPositionManagerOwnerActions {
) external;

/**
* @notice Called by owners to add quote tokens and receive a representative NFT.
* @notice Called by owners to mint and receive an Ajna Position NFT.
* @dev PositionNFTs can only be minited with an association to pools that have been deployed by the Ajna ERC20PoolFactory or ERC721PoolFactory.
* @param params Calldata struct supplying inputs required to mint a positions NFT.
* @return tokenId The tokenId of the newly minted NFT.
*/
Expand Down Expand Up @@ -104,4 +105,4 @@ interface IPositionManagerOwnerActions {
address pool; // The pool address associated with positions NFT
uint256[] indexes; // The array of bucket indexes to reedem positions for
}
}
}

0 comments on commit 2e1d8da

Please sign in to comment.