Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoolInfoUtils.momp reverts if there are no loans in the pool #702

Closed
EdNoepel opened this issue Mar 24, 2023 · 2 comments
Closed

PoolInfoUtils.momp reverts if there are no loans in the pool #702

EdNoepel opened this issue Mar 24, 2023 · 2 comments
Labels
Scope: Bug fix

Comments

@EdNoepel
Copy link
Contributor

PoolInfoUtils.momp reverts (presumably with a divide-by-zero) for pools with no loans. This was identified by the subgraph indexer.

What is the expected behavior in this use case? Should it behave like LUP and return MAX_PRICE?
@EdNoepel EdNoepel mentioned this issue Mar 24, 2023
Merged
@EdNoepel
Copy link
Contributor Author

Per today's design meeting, should return MAX_PRICE when there are no loans.

@EdNoepel EdNoepel mentioned this issue Mar 28, 2023
Merged
@EdNoepel
Copy link
Contributor Author

EdNoepel commented Apr 3, 2023

In review of PR, desired behavior was changed to return the HPB instead of MAX_PRICE. As such, should now be MIN_PRICE if there are no deposits in the pool.
Resolved by #712.

@EdNoepel EdNoepel closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Scope: Bug fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EdNoepel