Prevent DIV/0 revert calculating MOMP on a pool with no loans #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcushman
reviewed
Mar 29, 2023
src/PoolInfoUtils.sol
Outdated
| ( , , uint256 noOfLoans) = pool.loansInfo(); | ||
| noOfLoans += pool.totalAuctionsInPool(); | ||
| if (noOfLoans == 0) return MAX_PRICE; |
There was a problem hiding this comment.
What about returning the price of the top bucket? Basically replace Maths.wdiv(...)) below with 1?
There was a problem hiding this comment.
MAX_PRICE is the price of the top bucket.
There was a problem hiding this comment.
i mean top priced bucket with deposit > 0
There was a problem hiding this comment.
Done in e433d8cfba109191cdb67b74179836a7405d37d9; please re-review.
ith-harvey
reviewed
Apr 2, 2023
src/PoolInfoUtils.sol
Outdated
| @@ -15,6 +15,7 @@ import { | |||
| _priceAt, | |||
| _reserveAuctionPrice, | |||
| MAX_FENWICK_INDEX, | |||
| MAX_PRICE, | |||
There was a problem hiding this comment.
Why was MAX_PRICE added? I don't see it used, suggest it is removed.
There was a problem hiding this comment.
Removed in 111ce68.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
High level
Fix for #702
Description of bug or vulnerability and solution
Consumers should be able to calculate MOMP at any time, regardless of whether there is debt in the pool. When there are no borrowers, we define MOMP as the HPB. This means it will now be
MIN_PRICEif there is no liquidity on the book. There is no change to how MOMP is calculated for the first loan.Contract size
Pre Change
============ Deployment Bytecode Sizes ============
PoolInfoUtils - 11,773B (47.90%)
Post Change
============ Deployment Bytecode Sizes ============
PoolInfoUtils - 11,828B (48.13%)
Gas usage
This call would only cost gas if used in a transaction from a proxy contract or outside of the Ajna protocol.
Pre Change
Post Change