Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invariant code cleanup #1014

Closed
wants to merge 5 commits into from
Closed

Invariant code cleanup #1014

wants to merge 5 commits into from

Conversation

grandizzy
Copy link
Contributor

Description

Scope is to move all calls to Pool and PoolInfo in single helper so to make code more easy to maintain (if pool/ utils interfaces are changed there should be only one place to update) and to make code more readable.
Code cleanup too

Purpose

Impact

Tasks

  • Changes to protocol contracts are covered by unit tests executed by CI.
  • Protocol contract size limits have not been exceeded.
  • Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
  • Scope labels have been assigned as appropriate.
  • Invariant tests have been manually executed as appropriate for the nature of the change.

@prateek105
Copy link
Contributor

Closing this PR as changes are merged into PR #955.

@prateek105 prateek105 closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grandizzy @prateek105