Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sherlock 131.md: #577

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Sherlock 131.md: #577

merged 3 commits into from
Feb 8, 2023

Commits on Jan 12, 2023

  1. Create standardized PR templates for contracts (#539) 

    This PR creates three github PR templates that should be followed:
* `logic_src_changes.md`
* `cosmetic_src_changes.md`
* `testing_or_misc_nonsrc_changes.md`

To learn more about how GH templates work -> https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

Co-authored-by: Ian Harvey <iharvey@comcast.net>
    @ith-harvey
    ith-harvey and Ian Harvey committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c718d1f View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Single template (#546) 

    * merged all of the templates into one so the text will auto fill when a PR is created.
* was running into this issue documented here with auto fill -> https://stackoverflow.com/questions/52139192/github-pull-requests-template-not-showing
    @ith-harvey
    ith-harvey committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    f5ace44 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. add reentrancy guard to PositionManager.mint(); update mint natspec

    Mike committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ea276cf View commit details
    Browse the repository at this point in the history