Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sherlock 39: expiration timestamp and slippage control #600

Merged
merged 12 commits into from
Feb 12, 2023
Merged

Sherlock 39: expiration timestamp and slippage control #600

merged 12 commits into from
Feb 12, 2023

Commits on Feb 7, 2023

  1. ignore forge script tx broadcasts

    @EdNoepel
    EdNoepel committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    27de868 View commit details
    Browse the repository at this point in the history

  2. provide LUP limit when pulling collateral

    @EdNoepel
    EdNoepel committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    74677b2 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. expiration checks for adding to buckets

    @EdNoepel
    EdNoepel committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    fb30686 View commit details
    Browse the repository at this point in the history

  2. unit tests for addQuote and addCollateral expiration

    @EdNoepel
    EdNoepel committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    b36744d View commit details
    Browse the repository at this point in the history

  3. expiration checks for moveQuote

    @EdNoepel
    EdNoepel committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    90607bd View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. ensure borrower debt exceeds dust amount regardless of loan count

    @EdNoepel
    EdNoepel committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    c0a64f9 View commit details
    Browse the repository at this point in the history

  2. Revert "ensure borrower debt exceeds dust amount regardless of loan c… 

    …ount"

This reverts commit c0a64f9.
    @EdNoepel
    EdNoepel committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    4c6674d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-review' into 39.md

    @EdNoepel
    EdNoepel committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    eb7448f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix-review' into 39.md

    @EdNoepel
    EdNoepel committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    7b097ab View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. feedback from PR #600 (#604)

    @EdNoepel
    EdNoepel authored Feb 11, 2023
    Configuration menu
    Copy the full SHA
    cd1bc16 View commit details
    Browse the repository at this point in the history

  2. removed comment

    @EdNoepel
    EdNoepel committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    c15d036 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. Address review comments, update comment for _revertIfLupDroppedBelowL… ( 

    #607)

* Address review comments, update comment for _revertIfLupDroppedBelowLimit, changed LimitIndexReached to LimitIndexExceeded

* Remove lup Id variable, calculate LUP price directly

* Remove unused struct member
    @grandizzy
    grandizzy authored Feb 12, 2023
    Configuration menu
    Copy the full SHA
    5bab4a4 View commit details
    Browse the repository at this point in the history