Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transfer with permit #654

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Remove transfer with permit #654

merged 3 commits into from
Mar 6, 2023

Conversation

MikeHathaway
Copy link
Collaborator

@MikeHathaway MikeHathaway commented Mar 5, 2023

Description of change

High level

  • Removes unnecessary transferFromWithPermit method. We weren't using Permit as intended, as interactions with permit would normally occur in external contracts where the spender is the actual initiator of the transaction. There's no vulnerability, but I believe it's better to simply remove this function to simplify the code.
    • Removes unnecessary function and updates tests. Implements new contractNFTSpender utility contract to handle permit interactions.

Description of bug or vulnerability and solution

  • No vulnerability, but not useful either.

@MikeHathaway MikeHathaway changed the base branch from master to develop March 5, 2023 03:45
@grandizzy grandizzy merged commit ce21e3f into develop Mar 6, 2023
@grandizzy grandizzy deleted the remove-transferWithPermit branch March 6, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants