Pool maintanence #663
Merged
Pool maintanence #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorg interface functions and events based on their action
grandizzy
requested review from
MikeHathaway,
EdNoepel,
ith-harvey and
prateek105
EdNoepel
approved these changes
Mar 6, 2023
| /** | ||
| * @notice Called by lenders to update pool interest rate (can be updated only once in a 12 hours period of time). | ||
| */ | ||
| function updateInterest() external; |
There was a problem hiding this comment.
Unsure why this belongs in lender actions. Lender is incentivized to call when rate would go up, borrower is incentivized to call when rate would go down. Understand it needs to live somewhere. Maybe just update comment to remove by lenders?
There was a problem hiding this comment.
yep, renamed to by actors with 2512e5d (ideally we would have a separate InterestRate interface)
Merged
dmitriia
reviewed
Mar 6, 2023
| * @param owner LPs owner. | ||
| * @param spender Address approved to transfer LPs. | ||
| * @param indexes Bucket indexes of LPs approved. | ||
| * @param amounts LP amounts added (ordered by approved indexes). |
There was a problem hiding this comment.
Here it should be 'LP amounts removed'
dmitriia
reviewed
Mar 6, 2023
| * @dev Intended for use by the PositionManager contract. | ||
| * @param spender The new owner of the LPs. | ||
| * @param indexes Bucket indexes from where LPs are transferred. | ||
| * @param amounts The amounts of LPs approved to transfer. |
There was a problem hiding this comment.
updated in 70fc3b7
dmitriia
approved these changes
Mar 6, 2023
| * @dev write state: | ||
| * - increment LPs allowances | ||
| * @dev emit events: | ||
| * - SetLPsAllowance |
There was a problem hiding this comment.
yep, updated in c9fcfdc
| * @dev write state: | ||
| * - decrement LPs allowances | ||
| * @dev emit events: | ||
| * - SetLPsAllowance |
There was a problem hiding this comment.
updated in c9fcfdc
| * @dev write state: | ||
| * - decrement LPs allowances | ||
| * @dev emit events: | ||
| * - SetLPsAllowance |
There was a problem hiding this comment.
updated in c9fcfdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contract size before change
after change