Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to settle with reserves if reserves is 0 #740

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Do not try to settle with reserves if reserves is 0 #740

merged 1 commit into from
Apr 17, 2023

Conversation

grandizzy
Copy link
Contributor

@grandizzy grandizzy commented Apr 13, 2023 •
edited
Loading

Description of change

High level

  • Check if assets > liabilities before settle with reserves
  • save a Maths.floorWdiv and Maths.min operation if no reserve

@grandizzy grandizzy changed the title Do not try to settle with reserves if reserves is not positive Do not try to settle with reserves if reserves is 0 Apr 13, 2023
prateek105
prateek105 approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@prateek105 prateek105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

ith-harvey
ith-harvey approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@ith-harvey ith-harvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the PR template format, otherwise looks good.

@grandizzy grandizzy merged commit c869ef9 into develop Apr 17, 2023
@grandizzy grandizzy deleted the settle-with-reserves branch April 17, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ith-harvey ith-harvey ith-harvey approved these changes

@prateek105 prateek105 prateek105 approved these changes

@MikeHathaway MikeHathaway Awaiting requested review from MikeHathaway

@mattcushman mattcushman Awaiting requested review from mattcushman

@EdNoepel EdNoepel Awaiting requested review from EdNoepel

Assignees
No one assigned
Labels
Priority: Low Scope: Edits /src Scope: Gas Improvements Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grandizzy @prateek105 @ith-harvey