Forge 1.0 support #778
Merged
Forge 1.0 support #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all tests start with fake startPrank by calling _startTest() - through test helper methods only changePrank is used (as start prank ensured in _startTest())
grandizzy
force-pushed
the
forge-1.0-support
branch
from
6bb8811
to
7714df7
Compare
grandizzy
requested review from
EdNoepel,
prateek105,
MikeHathaway,
ith-harvey and
mattcushman
EdNoepel
approved these changes
Apr 30, 2023
There was a problem hiding this comment.
Looks cleaner. Just hope it doesn't break again when they fix foundry-rs/foundry#4826 .
Good point, thanks, wasn't aware of that issue. I'll set a watch on it |
ith-harvey
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests:
startPrankby calling_startTest()changePrankis used (as start prank ensured in_startTest())Gas load tests:
startPrankbefore using test helper functions (which usechangePrank)soptPrankafter using test helper functionsInvariant tests - in
useRandomActormodifier:startPrank, if that fails then fallback tochangePrankstopPrankas not needed (changePrankdoes stop/startPrank)Switch CI back to use nightly forge