Sherlock-31 Final: EIP 4494 compliance #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateek105
requested review from
MikeHathaway,
ith-harvey,
mattcushman,
grandizzy and
EdNoepel
| bytes4 interfaceId | ||
| ) public view virtual override returns (bool) { | ||
| return | ||
| interfaceId == type(IPermit).interfaceId || // 0x5604e225 |
There was a problem hiding this comment.
can just use the constant bytes4 in the equality check and have the derivation in the comment to save gas.
There was a problem hiding this comment.
Since this is less likely to be called from a contract in a transaction, I'm happy with it as-is for readability tradeoff.
grandizzy
changed the title
MikeHathaway
requested changes
Jun 26, 2023
I think the new function is only in interface that is overriden by existing one |
ith-harvey
previously requested changes
Jun 26, 2023
EdNoepel
approved these changes
Jun 28, 2023
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
High level
PermitERC721andPositionManagercontracts do not satisfy the requirements of theEIP-4494standard. Specifically, they lack the implementation of the IERC165 interface and do not indicate support for the 0x5604e225 interface. These discrepancies, mark the contracts as non-compliant with the EIP-4494 standard, which could lead to potential interoperability issues. Bauchibred - PositionManager & PermitERC721 do not comply with EIP-4494 sherlock-audit/2023-04-ajna-judging#31supportsInterfacefor EIP-4494 compliance