Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block addqt above auction price #997

Merged
merged 17 commits into from
Dec 4, 2023
Merged

Block addqt above auction price #997

merged 17 commits into from
Dec 4, 2023

Commits on Dec 1, 2023

  1. initial commit

    mwc committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    dcbb18e View commit details
    Browse the repository at this point in the history

  2. tweaks to Matt's PR to block adding quote token above auction price (#… 

    …1000)

* reduce cost of reference price assignment

* reduce pool contract size
    @EdNoepel
    EdNoepel committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ba38d6c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. fixed testDepositTakeAndSettleByRegularTakeSubsetPool

    mwc committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    61eb0f8 View commit details
    Browse the repository at this point in the history

  2. fixed tests in ERC20PoolLiquidationsArbTake.t.sol

    mwc committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    f78d812 View commit details
    Browse the repository at this point in the history

  3. fixed tests in ERC20PoolLiquidationsDepositTake.sol

    mwc committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    877f9ce View commit details
    Browse the repository at this point in the history

  4. fixed two more

    mwc committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    723d4bb View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. updated testDepositTakeAndSettleSubsetPool

    @EdNoepel
    EdNoepel committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    70f3b07 View commit details
    Browse the repository at this point in the history

  2. updated testKickAndSettleSubsetPoolFractionalCollateral

    @EdNoepel
    EdNoepel committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    54a8a1a View commit details
    Browse the repository at this point in the history

  3. updated testSettleWithDepositFuzzy

    @EdNoepel
    EdNoepel committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    bfebe3c View commit details
    Browse the repository at this point in the history

  4. Fixed final tests

    mwc committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    cd12a56 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'merge-rc9' into block-addqt-above-auction-price

    @EdNoepel
    EdNoepel committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    8048000 View commit details
    Browse the repository at this point in the history

  6. add "AddAboveAuctionPrice" as expected pool error

    @EdNoepel
    EdNoepel committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    2b3b930 View commit details
    Browse the repository at this point in the history

  7. implemented invariant A9: reference prices in liquidation queue shall… 

    … not decrease
    @EdNoepel
    EdNoepel committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    d632f2c View commit details
    Browse the repository at this point in the history

  8. Update assertAuction to use ThresholdPrice from auctionInfo (#1003) 

    * use auctionInfo thresholdprice instead of recalculating

* fix most tests

* update remaining tests

---------

Co-authored-by: Mike <mikehathaway@makerdao.com>
    @MikeHathaway
    MikeHathaway and Mike committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    a62d5c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Contract size mitigation (#1004) 

    * moved debtInfo to PoolCommons, saving 10 bytes

* moved withdrawBonds to KickerActions
    @EdNoepel
    EdNoepel committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    0f2cf48 View commit details
    Browse the repository at this point in the history

  2. added unit test showing adding qt above auction price reverts

    Ian Harvey committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    c5110e5 View commit details
    Browse the repository at this point in the history

  3. updated nit spellings

    Ian Harvey committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d5d0ca7 View commit details
    Browse the repository at this point in the history