GrantFund deployment #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GrantFund deployment
MikeHathaway
approved these changes
Jan 13, 2023
grandizzy
approved these changes
Jan 17, 2023
prateek105
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adjust the deployment process to use consistent environment variables.. Updated scripts to provide user feedback indicating contract deployment addresses. To prevent user error,
GrantFunddeployment calculates treasury size based on the total supply of AJNA tokens, per requirements.Makefileomits the--verifyswitch because contracts are not yet public. Dropped a-vto reduce stdout noise, since the user needs the console.logs. Using JSON keystores with interactive passwords as a best practice.Only changes to
src/are the README files, so this should have no audit impact.Deployed
GrantFundto Goerli and updated deployment page.Out of scope
BurnWrapperuntil we need it.--verify, and will redeploy to Goerli.