Voter delegation #34
Voter delegation #34
Conversation
src/grant-fund.ts
Outdated
| @@ -254,6 +249,15 @@ export function handleDistributionPeriodStarted( | |||
| distributionPeriod.startBlock = distributionStarted.startBlock | |||
| distributionPeriod.endBlock = distributionStarted.endBlock | |||
|
|
|||
| // loop through DistributionPeriodVotes for the current period and update voting power | |||
There was a problem hiding this comment.
I think we can actually just remove this code block entirely - at the time of a distribution periods start there won't be any DistributionPeriodVote to loop through as they can't be created until after
There was a problem hiding this comment.
The goal was to capture voting power after the snapshot period, before anyone actually votes. What's the best way to accomplish this?
There was a problem hiding this comment.
I think we would need to loop through all accounts, create a new loadOrCreateDistributionPeriodVote entity for that distribution period of the account. Then, call the contract for each account and then call just getScreeningStageVotePower.
We could just loop through accounts that had delegated
There was a problem hiding this comment.
AFAIK, there is no way to query the store for all entities of a specific type. Should we get the list of votes from the previous distribution period (if it exists), and create new DistributionPeriodVotes for each of those entities when the new distribution period starts?
There was a problem hiding this comment.
Yeah that sounds good to me. I can do that as part of my PR if you'd like to just get this merged
There was a problem hiding this comment.
Happy for you to do that in your branch. I will await your PR before merging this one.
* update FundingVote entity * fix todo * update FundingVote entity * fix todo * expand vote unit testing * fix fundingVote flow * fix votingPowerUsed calculation * cleanups * expand test assertions * wip distributionPeriod start screening power tracking * expand fundedSlate entity * add funds available to DistributionPeriod; improve treasury tracking * remove screeningStageVotingPower; rename fundingStage votingPower attributes * delete unused file * use wmul for fundsAvailable * fix FundedSlate bugs --------- Co-authored-by: Mike <mikehathaway@makerdao.com>
Index AJNA token contract for tracking voting delegation. Update voting power when each distribution period starts. Fold
Voterentity intoAccount. Other misc improvements.Has not been well-tested due to lack of tooling.