Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't update position in handleTransfer for burn address #79

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: don't update position in handleTransfer for burn address #79

merged 1 commit into from
Nov 8, 2023

Conversation

imbaniac
Copy link
Contributor

@imbaniac imbaniac commented Nov 8, 2023

Subgraph got stuck on trying to call getTokenURI for burned position token. I've added condition for checking burn address

EdNoepel
EdNoepel approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; much thanks. LMK if you need this deployed somewhere.

MikeHathaway
MikeHathaway approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

@imbaniac imbaniac merged commit 43ca0dc into develop Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

@EdNoepel EdNoepel EdNoepel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imbaniac @MikeHathaway @EdNoepel