feature/#1616 better user management #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
manuel-rw
commented
Dec 17, 2023
manuel-rw
commented
# Conflicts: # src/pages/manage/users/index.tsx
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
How does it look like in mobile? |
SeDemal
reviewed
Dec 18, 2023
There was a problem hiding this comment.
User's column in the main manage user's table looks bad on mobile, the icon, username and roles stack up. Otherwise mobile layout is nice.
Editing the email, it won't throw an error if the email format is not followed like it does for the account creation.
Deleting a user should bring you back to the manage page after the deletion.
As of now you can still stay on the page and do things (of which none will be saved anyway, but still a bit strange).
Saving a new password doesn't untick the confirm box. (Don't really know if it matters that much).
Edit page (Not the user management page, strictly the edit page) should be available to non admins for their own details.
That way users can update their own passwords and emails.
|
Addressed my own comment in this PR #1751 except users self management. |
truecharts-admin
referenced
this pull request
in truecharts/public
Dec 31, 2023
…45f163b by renovate (#16654) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/ajnart/homarr](https://togithub.com/ajnart/homarr) | patch | `0.14.2` -> `0.14.3` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ajnart/homarr (ghcr.io/ajnart/homarr)</summary> ### [`v0.14.3`](https://togithub.com/ajnart/homarr/releases/tag/v0.14.3) [Compare Source](https://togithub.com/ajnart/homarr/compare/v0.14.2...v0.14.3) ### 🎆🎆 Happy new Year! Thank you for all your support in 2023 - we really appreciate it. Homarr has been downloaded almost 4 million times with over 400'000 instances running the latest versions. Due to the increase in traffic, we have upgraded our website at https://homarr.dev/ significantly and moved our infrastructure to a hosting provider. We are looking forward to see you in 2024! #### Better user management  #### Redesigned torrent table Thanks to [@​InterN0te](https://togithub.com/InterN0te) , our torrent widget has received a great upgrade:  #### Gravatar support Homarr now integrates seamlessly with Gravatar. Simply upload a profile picture to Gravatar and you're good to go!  #### Updated docker integration We've added back the Docker integration to your boards. It's now easier to use than ever.   #### CLI tool Did you get locked out? Using our CLI tool, you can reset your password to recover your Homarr instance:  #### What's Changed - Update acceptableStatusCodes.ts by [@​jeffersonraimon](https://togithub.com/jeffersonraimon) in [https://github.com/ajnart/homarr/pull/1709](https://togithub.com/ajnart/homarr/pull/1709) - ✨ [#​1616](https://togithub.com/ajnart/homarr/issues/1616) Recovery script in Docker container by [@​manuel-rw](https://togithub.com/manuel-rw) in [https://github.com/ajnart/homarr/pull/1726](https://togithub.com/ajnart/homarr/pull/1726) - 🐛 About page and manage user pages not translated by [@​ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1724](https://togithub.com/ajnart/homarr/pull/1724) - ✨ Use gravatar with user email by [@​Tagaishi](https://togithub.com/Tagaishi) in [https://github.com/ajnart/homarr/pull/1688](https://togithub.com/ajnart/homarr/pull/1688) - Switch torrents Table to MantineReactTable with filter/sort function by [@​InterN0te](https://togithub.com/InterN0te) in [https://github.com/ajnart/homarr/pull/1557](https://togithub.com/ajnart/homarr/pull/1557) - ⚡️ Improve code in manage layout page by [@​Tagaishi](https://togithub.com/Tagaishi) in [https://github.com/ajnart/homarr/pull/1681](https://togithub.com/ajnart/homarr/pull/1681) - Updated entityStateSchema to handle nullables by [@​gfomichev](https://togithub.com/gfomichev) in [https://github.com/ajnart/homarr/pull/1744](https://togithub.com/ajnart/homarr/pull/1744) - feature/[#​1616](https://togithub.com/ajnart/homarr/issues/1616) better user management by [@​manuel-rw](https://togithub.com/manuel-rw) in [https://github.com/ajnart/homarr/pull/1748](https://togithub.com/ajnart/homarr/pull/1748) - New Crowdin updates by [@​ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1701](https://togithub.com/ajnart/homarr/pull/1701) - fix: umlaute in RSS by [@​manuel-rw](https://togithub.com/manuel-rw) in [https://github.com/ajnart/homarr/pull/1755](https://togithub.com/ajnart/homarr/pull/1755) - New Crowdin updates by [@​ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1761](https://togithub.com/ajnart/homarr/pull/1761) - ⚡️ Remove location based timezone resolving by [@​Tagaishi](https://togithub.com/Tagaishi) in [https://github.com/ajnart/homarr/pull/1680](https://togithub.com/ajnart/homarr/pull/1680) - Import to docker form board, Docker button on boards by [@​ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1714](https://togithub.com/ajnart/homarr/pull/1714) - Update FUNDING.yml by [@​ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1768](https://togithub.com/ajnart/homarr/pull/1768) - 🔧 Configure Stale Action by [@​manuel-rw](https://togithub.com/manuel-rw) in [https://github.com/ajnart/homarr/pull/1752](https://togithub.com/ajnart/homarr/pull/1752) - 🔧 Configure greetings by [@​manuel-rw](https://togithub.com/manuel-rw) in [https://github.com/ajnart/homarr/pull/1753](https://togithub.com/ajnart/homarr/pull/1753) - New Crowdin updates by [@​ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1770](https://togithub.com/ajnart/homarr/pull/1770) - fix: outdated config schema by [@​manuel-rw](https://togithub.com/manuel-rw) in [https://github.com/ajnart/homarr/pull/1769](https://togithub.com/ajnart/homarr/pull/1769) - chore: increase version in package.json by [@​manuel-rw](https://togithub.com/manuel-rw) in [https://github.com/ajnart/homarr/pull/1771](https://togithub.com/ajnart/homarr/pull/1771) - Docker import fix by [@​ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1773](https://togithub.com/ajnart/homarr/pull/1773) #### New Contributors - [@​jeffersonraimon](https://togithub.com/jeffersonraimon) made their first contribution in [https://github.com/ajnart/homarr/pull/1709](https://togithub.com/ajnart/homarr/pull/1709) - [@​gfomichev](https://togithub.com/gfomichev) made their first contribution in [https://github.com/ajnart/homarr/pull/1744](https://togithub.com/ajnart/homarr/pull/1744) **Full Changelog**: ajnart/homarr@v0.14.2...v0.14.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.