Add OMV integration / widget #1879

hillaliy · 2024-02-04T18:44:30Z

Screenshot (if applicable)

SeDemal

Overall nice.
You need to incorporate translation in basically every file though.
Send me a message if you need help for the strings that have variables in them.

We try to not use one specific app name to designate 1 widget as that widget could be subject to update and further integration with other apps. As such it would be nice to rename the widget to something more common.

.env.example

.vscode/settings.json

src/server/api/routers/openmediavault.ts

src/widgets/openmediavault/OpenMediaVaultCpu.tsx

src/widgets/openmediavault/OpenMediaVaultFileSystem.tsx

src/server/api/routers/openmediavault.ts

src/widgets/openmediavault/OpenMediaVaultCpu.tsx

src/widgets/openmediavault/OpenMediaVaultFileSystem.tsx

src/widgets/openmediavault/OpenMediaVaultMemory.tsx

manuel-rw · 2024-02-05T20:05:55Z

src/widgets/openmediavault/OpenMediaVaultTile.tsx

+  const formatUptime = (uptime: number) => {
+    const days = Math.floor(uptime / 60 / 60 / 24);
+    const remainingHours = Math.floor((uptime % (days * 24 * 60 * 60)) / 60 / 60);
+    return `${days} days & ${remainingHours} hours`;
+  };


Extract to a function in the helpers?

What do you mean?

I would move this function outside the widgets to the tools. We have files with these kind of functions

src/widgets/openmediavault/OpenMediaVaultTile.tsx

SeDemal

Overall very good changes.
Thanks for all the hard work it's really coming together nicely.

SeDemal · 2024-02-09T13:31:10Z

src/widgets/health-monitoring/HealthMonitoringCpu.tsx

+          {t('cpu.utilization')}: {info.cpuUtilization.toFixed(2)}%
+        </Text>
+        <Text fz="lg" tt="uppercase" fw={700} c="dimmed">
+          {fahrenheit


There's an already existing function in the Weather widget you could use, "getPerferedUnit".
It works with your current parameters.
Not important though, just in case.
If you do end up using it, you would need to extract it to "tools" and modify the weather widget too so don't worry too much about it.

src/widgets/health-monitoring/HealthMonitoringFileSystem.tsx

hillaliy · 2024-02-16T05:09:03Z

Hi @Tagaishi , I think you were right from the beginning, it is necessary to create a widget that will display data directly from the operating system and not from a certain integration

SeDemal · 2024-02-16T05:23:31Z

Hi @Tagaishi , I think you were right from the beginning, it is necessary to create a widget that will display data directly from the operating system and not from a certain integration

Actually the idea that somenoperating system offer more monitoring through their API could be something interesting to pursue. We just have to find a way to make it fit the template.
Both your integration and the one for proxmox are interesting.
As it is I will have to transfer things over at one point, most likely to your widget as the base. And I will combine those widgets together dynamically.
If you've addressed everything in the comments we might be able to merge soon and then you can add dashdot.

hillaliy · 2024-02-16T16:41:14Z

The last commit includes all comments fix.
I want to make some changes so I'll commit it soon

hillaliy · 2024-02-17T11:47:51Z

New design.

ajnart · 2024-02-23T13:24:46Z

@hillaliy Is the PR good to go now ? I think we can start resolving the conflict to merge it

hillaliy · 2024-02-23T14:38:02Z

I think you can merge

hillaliy · 2024-02-24T13:37:38Z

This is The new disign
The updates and reboot will appear only if available / require.

.env.example

.vscode/settings.json

src/widgets/health-monitoring/HealthMonitoringCpu.tsx

src/widgets/health-monitoring/HealthMonitoringFileSystem.tsx

src/widgets/health-monitoring/HealthMonitoringMemory.tsx

dslatt · 2024-03-04T17:40:56Z

@hillaliy where are you seeing the cputemp rpc? i don't see it as part of the rpc supported by omv

https://github.com/openmediavault/openmediavault/tree/master/deb/openmediavault/usr/share/openmediavault/engined/rpc

was getting errors when testing on my omv instance

hillaliy · 2024-03-04T17:53:49Z

You need to install CPU temp from OMV plugins.
Can you report that everything works?

dslatt · 2024-03-04T18:11:06Z

that makes sense. i'm running it as a vm so no actual temp data
i'll make the cputemp optional as part of #1903

…caf77d7 by renovate (#19304) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/ajnart/homarr](https://togithub.com/ajnart/homarr) | patch | `0.15.0` -> `0.15.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ajnart/homarr (ghcr.io/ajnart/homarr)</summary> ### [`v0.15.2`](https://togithub.com/ajnart/homarr/releases/tag/v0.15.2) [Compare Source](https://togithub.com/ajnart/homarr/compare/v0.15.1...v0.15.2) > \[!NOTE]\ > We've been working actively on working torwards version 1.0 which will include many improvements to performance, security and the overall look & feel of Homarr. It will greatly overhaul the technical architecture of Homarr. This work is done by volunteers. Please consider supporting our work via donations at https://opencollective.com/homarr #### v0.15.2: Hotfix, OMV 7 support - Fixed an issue with the image where it would notify you to upgrade to `0.15.1`, even though you were running `0.15.1` - Added support for OMV 7 - Updated Crowdin translations #### What's Changed - chore: increase version by [@manuel-rw](https://togithub.com/manuel-rw) in [https://github.com/ajnart/homarr/pull/1960](https://togithub.com/ajnart/homarr/pull/1960) - feat: OMV 7 support by [@hillaliy](https://togithub.com/hillaliy) in [https://github.com/ajnart/homarr/pull/1959](https://togithub.com/ajnart/homarr/pull/1959) - feat: Apply translation automation from select option to multi-select… by [@Tagaishi](https://togithub.com/Tagaishi) in [https://github.com/ajnart/homarr/pull/1963](https://togithub.com/ajnart/homarr/pull/1963) - chore: new Crowdin updates by [@ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1949](https://togithub.com/ajnart/homarr/pull/1949) - core: increase version to 0.15.2 by [@manuel-rw](https://togithub.com/manuel-rw) in [https://github.com/ajnart/homarr/pull/1967](https://togithub.com/ajnart/homarr/pull/1967) **Full Changelog**: ajnart/homarr@v0.15.1...v0.15.2 ### [`v0.15.1`](https://togithub.com/ajnart/homarr/releases/tag/v0.15.1) [Compare Source](https://togithub.com/ajnart/homarr/compare/v0.15.0...v0.15.1) > \[!NOTE]\ > We've been working actively on working torwards version 1.0 which will include many improvements to performance, security and the overall look & feel of Homarr. It will greatly overhaul the technical architecture of Homarr. This work is done by volunteers. Please consider supporting our work via donations at https://opencollective.com/homarr #### Version 0.15.1: Fixes wih SSO, OMV integration and weekly weather forecast ##### SSO fixes & improvements - Added environment variable `AUTH_OIDC_SCOPE_OVERWRITE` to override the OIDC scopes - Fixed redirection for OIDC logins - Added the environment variable `AUTH_LDAP_SEARCH_SCOPE` to modify the LDAP search scope between `base`, `one` or `sub`. - Added debug information on the login page when authentication providers are set incorrectly: ![310673082-a376bd01-e6bf-449b-93e8-f050da3fdef8](https://togithub.com/ajnart/homarr/assets/30572287/41c844b0-ce8b-43e4-80f8-526b20f2684b) ##### OMV widget [@hillaliy](https://togithub.com/hillaliy) has contributed a new system health widget that integrates with https://www.openmediavault.org/ ![image](https://togithub.com/ajnart/homarr/assets/30572287/13ea31ef-85f3-401c-a2e6-ca89783cf3ce) ##### Weekly forecast The weather widget can now display a weekly forecast: ![image](https://togithub.com/ajnart/homarr/assets/30572287/14fab53a-2caa-49be-8591-6f8b7afb9fb7) ##### Lithuanian and Estonian languange support We have added Lithuanian and Estonian to Homarr. As always, our community can translate Homarr into these languages: https://crowdin.com/project/homarr ##### Improved torrent tile performance & ordering Thanks to our contributors, the torrent widget now uses virtualization to lower the required work on the client when rendering the list of torrents. This results in more fluid scrolling and resizing of the widget: https://github.com/ajnart/homarr/assets/162878798/8a21eec2-2f6e-4b0b-8653-7cd730d7d697 Ordering columns is also now possible: ![](https://togithub.com/ajnart/homarr/assets/26098587/78e9636e-9ac5-44fe-aafc-d4df341ecf9b) #### What's Changed - feat: add environment variable to overwrite oidc scopes by [@Meierschlumpf](https://togithub.com/Meierschlumpf) in [https://github.com/ajnart/homarr/pull/1913](https://togithub.com/ajnart/homarr/pull/1913) - fix: redirect OIDC by [@Meierschlumpf](https://togithub.com/Meierschlumpf) in [https://github.com/ajnart/homarr/pull/1911](https://togithub.com/ajnart/homarr/pull/1911) - fix: set maximum size for indexer manager to 12 by [@Tagaishi](https://togithub.com/Tagaishi) in [https://github.com/ajnart/homarr/pull/1912](https://togithub.com/ajnart/homarr/pull/1912) - feat: add OMV integration / widget by [@hillaliy](https://togithub.com/hillaliy) in [https://github.com/ajnart/homarr/pull/1879](https://togithub.com/ajnart/homarr/pull/1879) - feat: add ldap search scope by [@Meierschlumpf](https://togithub.com/Meierschlumpf) in [https://github.com/ajnart/homarr/pull/1948](https://togithub.com/ajnart/homarr/pull/1948) - feat: AUTH_PROVIDER log when incorrect and show error in login page by [@Tagaishi](https://togithub.com/Tagaishi) in [https://github.com/ajnart/homarr/pull/1943](https://togithub.com/ajnart/homarr/pull/1943) - feat: add Lithuanian support by [@ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1935](https://togithub.com/ajnart/homarr/pull/1935) - feat: Mention Emby on Jellyfin integration by [@Tagaishi](https://togithub.com/Tagaishi) in [https://github.com/ajnart/homarr/pull/1917](https://togithub.com/ajnart/homarr/pull/1917) - feat: add weekly forecast to weather widget by [@hillaliy](https://togithub.com/hillaliy) in [https://github.com/ajnart/homarr/pull/1932](https://togithub.com/ajnart/homarr/pull/1932) - feat: add Estonian language by [@ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1931](https://togithub.com/ajnart/homarr/pull/1931) - chore: new Crowdin updates by [@ajnart](https://togithub.com/ajnart) in [https://github.com/ajnart/homarr/pull/1890](https://togithub.com/ajnart/homarr/pull/1890) - fix: death links in readme by [@Meierschlumpf](https://togithub.com/Meierschlumpf) in [https://github.com/ajnart/homarr/pull/1953](https://togithub.com/ajnart/homarr/pull/1953) - feat: Improve TorrentTile rendering performance by [@diederbert](https://togithub.com/diederbert) in [https://github.com/ajnart/homarr/pull/1951](https://togithub.com/ajnart/homarr/pull/1951) - fix: death app links by [@Meierschlumpf](https://togithub.com/Meierschlumpf) in [https://github.com/ajnart/homarr/pull/1955](https://togithub.com/ajnart/homarr/pull/1955) - feat: add column ordering in torrent widget by [@hillaliy](https://togithub.com/hillaliy) in [https://github.com/ajnart/homarr/pull/1952](https://togithub.com/ajnart/homarr/pull/1952) #### New Contributors - [@diederbert](https://togithub.com/diederbert) made their first contribution in [https://github.com/ajnart/homarr/pull/1951](https://togithub.com/ajnart/homarr/pull/1951) **Full Changelog**: ajnart/homarr@v0.15.0...v0.15.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

SeDemal requested changes Feb 5, 2024

View reviewed changes

manuel-rw requested changes Feb 5, 2024

View reviewed changes

SeDemal reviewed Feb 5, 2024

View reviewed changes

src/widgets/openmediavault/OpenMediaVaultTile.tsx Outdated Show resolved Hide resolved

SeDemal reviewed Feb 9, 2024

View reviewed changes

SeDemal mentioned this pull request Feb 16, 2024

Add Proxmox integration/widget #1903

Merged

manuel-rw force-pushed the openmediavault branch from 69e5c86 to cb41834 Compare February 25, 2024 18:41

feat: open media vault widget

1a5efb4

manuel-rw force-pushed the openmediavault branch from cb41834 to 1a5efb4 Compare February 25, 2024 18:43

manuel-rw previously approved these changes Feb 25, 2024

View reviewed changes

SeDemal requested changes Feb 25, 2024

View reviewed changes

Fix all

c9a2397

hillaliy dismissed manuel-rw’s stale review via c9a2397 February 27, 2024 04:14

hillaliy added 4 commits February 27, 2024 19:30

settings.json

1507ffc

fix cpu load average translate

5339b4e

.env.example

53fbef8

add colors to disk / mem rings

503c898

SeDemal approved these changes Feb 27, 2024

View reviewed changes

SeDemal merged commit b51fcdb into ajnart:dev Feb 27, 2024
2 checks passed

hillaliy deleted the openmediavault branch February 27, 2024 20:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add OMV integration / widget #1879

Add OMV integration / widget #1879

hillaliy commented Feb 4, 2024 •

edited

Loading

SeDemal left a comment

manuel-rw Feb 5, 2024

hillaliy Feb 7, 2024

manuel-rw Feb 8, 2024

SeDemal left a comment

SeDemal Feb 9, 2024

hillaliy commented Feb 16, 2024 •

edited

Loading

SeDemal commented Feb 16, 2024

hillaliy commented Feb 16, 2024 •

edited

Loading

hillaliy commented Feb 17, 2024

ajnart commented Feb 23, 2024

hillaliy commented Feb 23, 2024

hillaliy commented Feb 24, 2024 •

edited

Loading

dslatt commented Mar 4, 2024

hillaliy commented Mar 4, 2024 •

edited

Loading

dslatt commented Mar 4, 2024

Add OMV integration / widget #1879

Add OMV integration / widget #1879

Conversation

hillaliy commented Feb 4, 2024 • edited Loading

Category

Screenshot (if applicable)

SeDemal left a comment

Choose a reason for hiding this comment

manuel-rw Feb 5, 2024

Choose a reason for hiding this comment

hillaliy Feb 7, 2024

Choose a reason for hiding this comment

manuel-rw Feb 8, 2024

Choose a reason for hiding this comment

SeDemal left a comment

Choose a reason for hiding this comment

SeDemal Feb 9, 2024

Choose a reason for hiding this comment

hillaliy commented Feb 16, 2024 • edited Loading

SeDemal commented Feb 16, 2024

hillaliy commented Feb 16, 2024 • edited Loading

hillaliy commented Feb 17, 2024

ajnart commented Feb 23, 2024

hillaliy commented Feb 23, 2024

hillaliy commented Feb 24, 2024 • edited Loading

dslatt commented Mar 4, 2024

hillaliy commented Mar 4, 2024 • edited Loading

dslatt commented Mar 4, 2024

hillaliy commented Feb 4, 2024 •

edited

Loading

hillaliy commented Feb 16, 2024 •

edited

Loading

hillaliy commented Feb 16, 2024 •

edited

Loading

hillaliy commented Feb 24, 2024 •

edited

Loading

hillaliy commented Mar 4, 2024 •

edited

Loading