Added an option for noreferrer #2048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
manuel-rw
approved these changes
May 15, 2024
|
Actually can you make this default behavior ? (Remove the option and add it by default) |
|
This should be probably be noted as a separate issue but I just noticed that after updating the PR the review status didn't change. You may want to update your repo settings so people can't push code after a review is complete but before the PR is merged. |
|
@H3phaist0s as you've removed the switch you can probably revert also the changes in |
bebsworthy
added a commit
to bebsworthy/homarr
that referenced
this pull request
Sep 10, 2024
reference: Issue: ajnart#1933 PR comment: ajnart#2048 (comment)
SeDemal
pushed a commit
that referenced
this pull request
Sep 15, 2024
reference: Issue: #1933 PR comment: #2048 (comment)
Meierschlumpf
added a commit
that referenced
this pull request
Oct 18, 2024
* fix: app ping retry interval * Bugfix for dynamic urls not properly replaces on Search (#2124) * Bugfix for search items * Fixing server side rendering issues * Add rel="noreferrer" to link AppTile.tsx (#2126) reference: Issue: #1933 PR comment: #2048 (comment) * fix: Make timer button show only to admins (#2143) * fix: wrong redirect url for oidc requests #1909 (#2149) * fix: wrong redirect url for oidc requests #1909 * fix: login not working with https * chore: New Crowdin updates (#2123) * New translations health-monitoring.json (Greek) * New translations login.json (French) * New translations customize.json (French) --------- Co-authored-by: Manuel <30572287+manuel-rw@users.noreply.github.com> Co-authored-by: Jelte Lagendijk <j3lte@users.noreply.github.com> Co-authored-by: Boyd <bebsworthy@gmail.com> Co-authored-by: SeDemal <Tagaishi@hotmail.ch> Co-authored-by: Thomas Camlong <thomas@ajnart.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Overview
Issue Number (if applicable)
Screenshot (if applicable)